From: Phil Edworthy <phil.edworthy@renesas.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Hoan Tran <hotran@apm.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Michel Pollet" <michel.pollet@bp.renesas.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] gpio: dwapb: Add support for 32 interrupts
Date: Thu, 5 Apr 2018 09:42:46 +0000 [thread overview]
Message-ID: <TY1PR01MB1769064C77AE3E5ABA4993DAF5BB0@TY1PR01MB1769.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VeOTjZ30ok1JOW0cefZfxqUM-f0-zpTnC5TonyeqQVUKg@mail.gmail.com>
Hi Andy,
On 30 March 2018 22:26 Andy Shevchenko wrote:
> On Wed, Mar 28, 2018 at 5:22 PM, Phil Edworthy wrote:
> > The DesignWare GPIO IP can be configured for either 1 or 32
> > interrupts,
>
> 1 to 32, or just a choice between two?
Just a choice of 1 or 32.
Note that by 'configured' I am talking about the hardware being configured in
RTL prior to manufacturing a device. Once made, you cannot change it.
This configuration affects the number of output interrupt signals from the GPIO
Controller block that are connected to an interrupt controller.
> > but the driver currently only supports 1 interrupt. See the DesignWare
> > DW_apb_gpio Databook description of the 'GPIO_INTR_IO' parameter.
>
> Will see after holiday and perhaps make more comments. Here is just a brief
> review.
>
> > +- interrupts : The interrupts to the parent controller raised when
> > +GPIOs
> > + generate the interrupts. If the controller provides one combined
> > +interrupt
> > + for all GPIOs, specify a single interrupt. If the controller
> > +provides one
> > + interrupt for each GPIO, provide a list of interrupts that
> > +correspond to each
> > + of the GPIO pins. When specifying multiple interrupts, if any of
> > +the GPIOs are
> > + not connected to an interrupt, use the interrupt-mask property.
> > +- interrupt-mask : a 32-bit bit mask that specifies which interrupts
> > +in the list
> > + of interrupts is valid, bit is 1 for a valid irq.
>
> So, but why one will need that in practice? GPIO driver usually provides a pin
> based IRQ chip which maps each pin to the corresponding offset inside
> specific IRQ domain.
On an ARM device we have this GPIO block connected to the GIC interrupt
controller, i.e. the Synopsys GPIO controller interrupts can* have a 1 to 1
mapping to the GIC interrupts. At the moment, the GPIO driver only allows a
single irq signal to specified.
* this is not strictly accurate on the device I am working on, there is another
block of IP between the two, but that doesn't matter in this case.
> > + struct device_node *np = to_of_node(fwnode);
> > + u32 irq_mask = 0xFFFFFFFF;
>
> Why? Shouldn't it be dependent to the amount of actual pins / ports?
> Intel Quark has only 8 AFAIR.
It's just a default which can be overridden via device tree.
For Quark, since you currently only use a single irq, I guess the HW was
configured that way. In which case, you wouldn't use any of this.
> > + int j;
> > +
> > + /* Optional irq mask */
> > + fwnode_property_read_u32(fwnode,
> > + "interrupt-mask", &irq_mask);
> > +
> > + /*
> > + * The IP has configuration options to allow a single
> > + * combined interrupt or one per gpio. If one per gpio,
> > + * some might not be used.
> > + */
>
> > + for (j = 0; j < pp->ngpio; j++) {
> > + if (irq_mask & BIT(j)) {
>
> for_each_set_bit() is in kernel for ages!
There's lot of stuff in the kernel for ages that I can't remember!
I'll fix this :)
> > + pp->irq[j] = irq_of_parse_and_map(np, j);
> > + if (pp->irq[j])
> > + pp->has_irq = true;
> > + }
> > + }
>
>
> So, on the first glance the patch looks either superfluous or taking wrong
> approach. Please, elaborate more why it's done in this way and what the
> case for all this in practice.
Hopefully I have explained it a bit better above.
Thanks for your comments
Phil
next prev parent reply other threads:[~2018-04-05 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 14:22 Phil Edworthy
2018-03-29 9:39 ` Phil Edworthy
2018-03-30 21:26 ` Andy Shevchenko
2018-04-05 9:42 ` Phil Edworthy [this message]
2018-04-06 9:57 ` Geert Uytterhoeven
2018-04-06 10:20 ` Phil Edworthy
2018-04-11 10:17 ` Phil Edworthy
2018-04-09 19:20 ` Rob Herring
2018-04-10 6:24 ` Phil Edworthy
2018-04-10 14:23 ` Phil Edworthy
2018-04-10 14:29 ` Geert Uytterhoeven
2018-04-10 15:00 ` Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR01MB1769064C77AE3E5ABA4993DAF5BB0@TY1PR01MB1769.jpnprd01.prod.outlook.com \
--to=phil.edworthy@renesas.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hotran@apm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michel.pollet@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®