From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935365AbdKQRky (ORCPT ); Fri, 17 Nov 2017 12:40:54 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:63897 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966221AbdKQRkn (ORCPT ); Fri, 17 Nov 2017 12:40:43 -0500 X-IronPort-AV: E=Sophos;i="5.44,410,1505746800"; d="scan'208";a="263811753" From: Fabrizio Castro To: Cyrille Pitchen , David Woodhouse , Brian Norris , "Boris Brezillon" , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland CC: "devicetree@vger.kernel.org" , Chris Paterson , "linux-kernel@vger.kernel.org" , Biju Das , "linux-mtd@lists.infradead.org" Subject: RE: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names Thread-Topic: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names Thread-Index: AQHTTM8W5Jj9hg8/20SEleSRit+JKKMY+6IAgAAAn3A= Date: Fri, 17 Nov 2017 17:40:38 +0000 Message-ID: References: <1505118928-3987-1-git-send-email-fabrizio.castro@bp.renesas.com> <1508853032-25229-1-git-send-email-fabrizio.castro@bp.renesas.com> <658ceb2b-5d2b-9349-f140-27858459e5a8@wedev4u.fr> In-Reply-To: <658ceb2b-5d2b-9349-f140-27858459e5a8@wedev4u.fr> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fabrizio.castro@bp.renesas.com; x-originating-ip: [193.141.220.21] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TY1PR06MB0702;20:XP5ZtvBbnxWlLhcHadDiyiGP9ue2qXa5ElqxGUhWOxHZjx6sCdvG3kv3CpbOQHulpFvPOAEDvdTWbCbgXHKOKdFdZ521xYwUPNG5u+9LEyGTxqKrhwfnsyTWIgrOG+TTmI2TA3FGR0dOOrt6m/zY0cLUYcSng+BQlMNYGXkJrJk= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: c0502c6a-003a-4dee-0d81-08d52de250da x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:TY1PR06MB0702; x-ms-traffictypediagnostic: TY1PR06MB0702: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:TY1PR06MB0702;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:TY1PR06MB0702; x-forefront-prvs: 049486C505 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(54534003)(86362001)(8936002)(39060400002)(3846002)(189998001)(316002)(106356001)(54356999)(7736002)(76176999)(50986999)(305945005)(33656002)(101416001)(25786009)(54906003)(97736004)(68736007)(105586002)(81166006)(81156014)(74316002)(102836003)(14454004)(6116002)(110136005)(478600001)(2950100002)(8676002)(4326008)(42882006)(6246003)(66066001)(229853002)(6506006)(3660700001)(6306002)(53936002)(77096006)(99286004)(345774005)(7416002)(6436002)(9686003)(2900100001)(7696004)(3280700002)(5660300001)(2906002)(55016002)(966005);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR06MB0702;H:TY1PR06MB0895.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0502c6a-003a-4dee-0d81-08d52de250da X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2017 17:40:38.3557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0702 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAHHew60006255 Hello Cyrille, it's ok, thank you for the feedback. Best regards, Fab > Hi Fabrizio, > > sorry but I won't apply this patch. > > New values for the 'compatible' DT properties should only be added for > memory parts not supporting the JEDEC READ ID (0x9F) command. > > SST25 memories do support this command hence should use the "jedec,spi-nor" > value alone. For historical reasons, some DT nodes set their 'compatible' > string to something like ",", "jedec,spi-nor". > It should work as expected in most case however I discourage from doing so > in new device trees because it may have some side effects especially when > the m25p80.c driver is used between the spi-nor.c driver and the SPI > controller driver. > > It's all about setting the 2nd parameter of spi_nor_scan(), the 'name' > parameter, as NULL when possible. This parameter should be set to a non NULL > value only for memories not supporting the JEDEC READ ID op code (0x9F). > > Best regards, > > Cyrille > > Le 24/10/2017 à 15:50, Fabrizio Castro a écrit : > > There are a few DT files that make use of sst25vf016b in their > > compatible strings, and the driver supports this chip already. > > This patch improves the documentation and therefore the result > > of ./scripts/checkpatch.pl. > > > > Signed-off-by: Fabrizio Castro > > Signed-off-by: Chris Paterson > > Acked-by: Rob Herring > > Acked-by: Geert Uytterhoeven > > --- > > Thank you Rob, thank you Geert, and sorry for the delay on this one. > > Here is v2. > > > > Changes in v2: > > * fixed subject prefix > > * added changelog > > > > Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi- > nor.txt > > index 4cab5d8..bf56d77 100644 > > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > > @@ -31,6 +31,7 @@ Required properties: > > s25sl12801 > > s25fl008k > > s25fl064k > > + sst25vf016b > > sst25vf040b > > sst25wf040b > > m25p40 > > > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.