From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502AbdLNJpE (ORCPT ); Thu, 14 Dec 2017 04:45:04 -0500 Received: from relmlor3.renesas.com ([210.160.252.173]:59610 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751226AbdLNJpB (ORCPT ); Thu, 14 Dec 2017 04:45:01 -0500 X-IronPort-AV: E=Sophos;i="5.45,400,1508770800"; d="scan'208";a="265117626" From: Yoshihiro Shimoda To: Geert Uytterhoeven CC: Kishon Vijay Abraham I , Rob Herring , Mark Rutland , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Linux-Renesas Subject: RE: [PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling Thread-Topic: [PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling Thread-Index: AQHTc9wVZ1VFOCZucEKRcdSRDWIklqNA+HgAgAGfvDA= Date: Thu, 14 Dec 2017 09:44:57 +0000 Message-ID: References: <1513146460-20326-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1513146460-20326-6-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.139] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TY1PR06MB0989;20:CE9IxrmMPYAjO3awFD7Dof3825qc1oknKh1OHAdmShDrp2B8qPp/x7r/kXruu53ApS/2P66aVbXOf5FtvcWXej2i0Vs1pW4IBOBYwYD3m6mOtxS6MMJ6B3ZxcKDftGZxWLHTU6pdt1T9UW4c2ruw+nB4xCcMgMgrzt1AvM3e2vA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8121b31c-8fed-4ec5-52f2-08d542d7564f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307);SRVR:TY1PR06MB0989; x-ms-traffictypediagnostic: TY1PR06MB0989: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231023)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123562025)(6072148)(201708071742011);SRVR:TY1PR06MB0989;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:TY1PR06MB0989; x-forefront-prvs: 05214FD68E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(346002)(366004)(39860400002)(376002)(24454002)(189003)(199004)(7696005)(14454004)(6916009)(3280700002)(6436002)(478600001)(86362001)(105586002)(68736007)(106356001)(5660300001)(53546011)(25786009)(4326008)(2950100002)(6506007)(54906003)(316002)(59450400001)(97736004)(99286004)(76176011)(55016002)(2900100001)(8936002)(102836003)(3846002)(345774005)(33656002)(53936002)(6246003)(9686003)(81156014)(8676002)(2906002)(77096006)(3660700001)(7736002)(305945005)(229853002)(81166006)(74316002)(230783001)(6116002)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR06MB0989;H:TY1PR06MB0992.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8121b31c-8fed-4ec5-52f2-08d542d7564f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2017 09:44:57.4046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0989 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBE9j9eJ030420 Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, December 13, 2017 5:55 PM > > Hi Shimoda-san, > > On Wed, Dec 13, 2017 at 7:27 AM, Yoshihiro Shimoda > wrote: > > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS > > and ID. So, they may be connected to gpio pins. To handle the gpio > > pins, this patch adds the handling of VBUS and ID pins instead of > > dedicated pins. > > > > Signed-off-by: Yoshihiro Shimoda > > --- > > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 + > > drivers/phy/renesas/phy-rcar-gen3-usb2.c | 77 ++++++++++++++++++++-- > > 2 files changed, 72 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > index 99b651b..851582f 100644 > > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > @@ -27,6 +27,8 @@ channel as USB OTG: > > - interrupts: interrupt specifier for the PHY. > > - vbus-supply: Phandle to a regulator that provides power to the VBUS. This > > regulator will be managed during the PHY power on/off sequence. > > +- renesas,vbus-gpios: use gpio to control vbus instead of dedicated pin. > > +- renesas,id-gpios: use gpio to detect id instead of dedicated pin. > > Documentation/devicetree/bindings/phy/brcm,ns2-drd-phy.txt already uses > "vbus-gpios" and "id-gpios" without vendor-specific prefixes, so perhaps > the "renesas," can be dropped? Thank you for the comments. I agree with you. So, I'll drop "renesas," in v2. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds