From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbdK3Mvw (ORCPT ); Thu, 30 Nov 2017 07:51:52 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:64189 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751099AbdK3Mvu (ORCPT ); Thu, 30 Nov 2017 07:51:50 -0500 X-IronPort-AV: E=Sophos;i="5.45,341,1508770800"; d="scan'208";a="263777451" From: Yoshihiro Shimoda To: Ulf Hansson , Geert Uytterhoeven CC: "Rafael J. Wysocki" , Linux PM , LKML , "Greg Kroah-Hartman" , Alan Stern , USB list , Linux-Renesas Subject: RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status() Thread-Topic: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status() Thread-Index: AQHTaDfS0q/eL1h6GUu734kOFriem6MpuB9wgABSgACAAPMO0IAAGbSAgAAFNYCAAARrAIABvQIA Date: Thu, 30 Nov 2017 12:51:45 +0000 Message-ID: References: <1713438.irjm9MTSvo@aspire.rjw.lan> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.139] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TY1PR06MB0991;20:nhWa0rq/C7MOSL3fymHvaalLg4LEUdC0F5BlFu0Ng5SIBqDrhjWXF759Mi2VE3IrhOxTKOPdlNtsKKa7MSQO9rvUdF5uUQx3BTL4YtT1QOHXEZ22pS32Qo/07yHp3W9HVwiJfF/dECuyWKm4jUIqDYneeeyWYjsNIZrFeeGtEvY= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 978f1c4f-ff40-40a6-2066-08d537f11d21 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286);SRVR:TY1PR06MB0991; x-ms-traffictypediagnostic: TY1PR06MB0991: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231022)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(6072148)(201708071742011);SRVR:TY1PR06MB0991;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:TY1PR06MB0991; x-forefront-prvs: 05079D8470 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(39860400002)(366004)(24454002)(199003)(189002)(74316002)(6246003)(14454004)(2900100001)(2950100002)(55016002)(4326008)(102836003)(5660300001)(189998001)(110136005)(6116002)(305945005)(3846002)(7736002)(105586002)(9686003)(25786009)(77096006)(229853002)(106356001)(99286004)(101416001)(33656002)(68736007)(316002)(8676002)(66066001)(8936002)(53546010)(6436002)(93886005)(86362001)(54906003)(81156014)(81166006)(3280700002)(97736004)(2906002)(6506006)(53936002)(7696005)(76176010)(50986010)(3660700001)(478600001)(54356010);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR06MB0991;H:TY1PR06MB0992.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 978f1c4f-ff40-40a6-2066-08d537f11d21 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2017 12:51:45.5805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0991 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAUCpv2t010461 Hi, > From: Ulf Hansson, Sent: Wednesday, November 29, 2017 6:59 PM > > On 29 November 2017 at 10:43, Geert Uytterhoeven wrote: > > Hi Ulf, > Okay, so the problem remains no matter which solution for wakeup you > pick in genpd. Yes. Today I could reproduce this issue without usb host driver. - The renesas_usb3 usb peripheral driver has generic phy handling. (The peripheral driver uses different generic phy driver (phy-rcar-gen3-usb3.c) though.) --> If I used the current renesas_usb3 (this means doesn't call phy_power_{on,off}(), the issue didn't happen. --> If I added phy_power_{on,off}() calling, the issue happened. --> So, I'm thinking the APIs are related to the issue. - The generic phy APIs are in drivers/phy/phy-core.c. --> The phy-rcar-gen3-usb[23] drivers call only pm_runtime_enable() before devm_phy_create(). --> The phy-core will call pm_runtime_{get_sync,put}() in phy_{init,exit,power_{on,off}}. --> So, IIUC, both devices of phy-. and will be handled by runtime PM APIs. --> The runtime PM implementation of phy-core seems good to me. But...? > Then this seems to point to that the driver may be misbehaving in some > way. I can help to check what is going on. I guess so. But, I don't find yet... Best regards, Yoshihiro Shimoda > Kind regards > Uffe