Re: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is enabled

[Shengyu Qu <wiagn233@outlook.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1014 bytes --]

You are right. I'm thinking about changing the code like this:

#ifdef CONFIG_NET_MEDIATEK_SOC_WED
	if (mtk_wed_device_active(&dev->mt76.mmio.wed)) {
		if (is_mt7915(&dev->mt76) ||
		    !mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
			ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY),
						0, 0, 0);
		else
			ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(SET),
						MCU_WA_PARAM_WED_VERSION,
						dev->mt76.mmio.wed.rev_id, 0);
		if (ret)
			return ret;
	}
#endif

Do you think this is ok?

Best regards,
Shengyu

在 2024/8/4 17:56, Kalle Valo 写道:
> Shengyu Qu <wiagn233@outlook.com> writes:
> 
>> This error report is a false warning. "struct mtk_wed_device" needs
>> "CONFIG_NET_MEDIATEK_SOC_WED" to be defined.
> 
> I didn't investigate anything but based on your description that sounds
> wrong. The code should should not be compiled if it depends on
> CONFIG_NET_MEDIATEK_SOC_WED but that's not set. We have zero rule for
> compilation errors or warnings.
> 

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]