From: Biju Das <biju.das.jz@bp.renesas.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
biju.das.au <biju.das.au@gmail.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
magnus.damm <magnus.damm@gmail.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3 1/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Use pattern for interrupt-names
Date: Sat, 7 Feb 2026 11:19:55 +0000 [thread overview]
Message-ID: <TY3PR01MB113465DF3134440209DFD94058667A@TY3PR01MB11346.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20260207-spiritual-victorious-wren-519a0f@quoll>
Hi Krzysztof Kozlowski,
Thanks for the feedback.
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 07 February 2026 10:34
> Subject: Re: [PATCH v3 1/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Use pattern for
> interrupt-names
>
> On Fri, Feb 06, 2026 at 11:16:44AM +0000, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Simplify the bindings by using pattern property for interrupt-names.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v2->v3:
> > * No change
> > v1->v2:
> > * New patch.
> > ---
> > .../renesas,rzg2l-irqc.yaml | 120 ++++--------------
> > 1 file changed, 23 insertions(+), 97 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l
> > -irqc.yaml
> > b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l
> > -irqc.yaml index 44b6ae5fc802..a0b57d808639 100644
> > ---
> > a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l
> > -irqc.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,r
> > +++ zg2l-irqc.yaml
> > @@ -48,107 +48,33 @@ properties:
> >
> > interrupts:
> > minItems: 45
> > - items:
> > - - description: NMI interrupt
> > - - description: IRQ0 interrupt
>
> I do not understand how this is related to simplifying interrupt-names.
The list keeps growing, this change simplifies for RZ/G3L SoC that has 61 interrupts.
and it is not something new in bindings see [1]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/net/snps,dwmac.yaml?h=next-20260205#n125
>
> > - - description: IRQ1 interrupt
> > - - description: IRQ2 interrupt
> > - - description: IRQ3 interrupt
> > - - description: IRQ4 interrupt
> > - - description: IRQ5 interrupt
> > - - description: IRQ6 interrupt
> > - - description: IRQ7 interrupt
> > - - description: GPIO interrupt, TINT0
> > - - description: GPIO interrupt, TINT1
> > - - description: GPIO interrupt, TINT2
> > - - description: GPIO interrupt, TINT3
> > - - description: GPIO interrupt, TINT4
> > - - description: GPIO interrupt, TINT5
> > - - description: GPIO interrupt, TINT6
> > - - description: GPIO interrupt, TINT7
> > - - description: GPIO interrupt, TINT8
> > - - description: GPIO interrupt, TINT9
> > - - description: GPIO interrupt, TINT10
> > - - description: GPIO interrupt, TINT11
> > - - description: GPIO interrupt, TINT12
> > - - description: GPIO interrupt, TINT13
> > - - description: GPIO interrupt, TINT14
> > - - description: GPIO interrupt, TINT15
> > - - description: GPIO interrupt, TINT16
> > - - description: GPIO interrupt, TINT17
> > - - description: GPIO interrupt, TINT18
> > - - description: GPIO interrupt, TINT19
> > - - description: GPIO interrupt, TINT20
> > - - description: GPIO interrupt, TINT21
> > - - description: GPIO interrupt, TINT22
> > - - description: GPIO interrupt, TINT23
> > - - description: GPIO interrupt, TINT24
> > - - description: GPIO interrupt, TINT25
> > - - description: GPIO interrupt, TINT26
> > - - description: GPIO interrupt, TINT27
> > - - description: GPIO interrupt, TINT28
> > - - description: GPIO interrupt, TINT29
> > - - description: GPIO interrupt, TINT30
> > - - description: GPIO interrupt, TINT31
> > - - description: Bus error interrupt
> > - - description: ECCRAM0 or combined ECCRAM0/1 1bit error interrupt
> > - - description: ECCRAM0 or combined ECCRAM0/1 2bit error interrupt
> > - - description: ECCRAM0 or combined ECCRAM0/1 error overflow interrupt
> > - - description: ECCRAM1 1bit error interrupt
> > - - description: ECCRAM1 2bit error interrupt
> > - - description: ECCRAM1 error overflow interrupt
> > + maxItems: 48
> >
> > interrupt-names:
> > minItems: 45
> > + maxItems: 48
> > items:
> > - - const: nmi
> > - - const: irq0
> > - - const: irq1
> > - - const: irq2
> > - - const: irq3
> > - - const: irq4
> > - - const: irq5
> > - - const: irq6
> > - - const: irq7
> > - - const: tint0
> > - - const: tint1
> > - - const: tint2
> > - - const: tint3
> > - - const: tint4
> > - - const: tint5
> > - - const: tint6
> > - - const: tint7
> > - - const: tint8
> > - - const: tint9
> > - - const: tint10
> > - - const: tint11
> > - - const: tint12
> > - - const: tint13
> > - - const: tint14
> > - - const: tint15
> > - - const: tint16
> > - - const: tint17
> > - - const: tint18
> > - - const: tint19
> > - - const: tint20
> > - - const: tint21
> > - - const: tint22
> > - - const: tint23
> > - - const: tint24
> > - - const: tint25
> > - - const: tint26
> > - - const: tint27
> > - - const: tint28
> > - - const: tint29
> > - - const: tint30
> > - - const: tint31
> > - - const: bus-err
> > - - const: ec7tie1-0
> > - - const: ec7tie2-0
> > - - const: ec7tiovf-0
> > - - const: ec7tie1-1
> > - - const: ec7tie2-1
> > - - const: ec7tiovf-1
> > + oneOf:
> > + - description: NMI interrupt
> > + const: nmi
>
> Your commit msg is completely inaccurate. You are not simplifying, you are CHANGING by allowing any
> order.
You are correct, apart from keep adding more interrupts in description and items,
it allows to change by any order based on the pattern.
Cheers,
Biju
next prev parent reply other threads:[~2026-02-07 11:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 11:16 [PATCH v3 0/9] Add RZ/G3L IRQC support Biju
2026-02-06 11:16 ` [PATCH v3 1/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Use pattern for interrupt-names Biju
2026-02-07 10:33 ` Krzysztof Kozlowski
2026-02-07 11:19 ` Biju Das [this message]
2026-02-06 11:16 ` [PATCH v3 2/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/G3L SoC Biju
2026-02-07 10:35 ` Krzysztof Kozlowski
2026-02-07 11:24 ` Biju Das
2026-02-06 11:16 ` [PATCH v3 3/9] irqchip/renesas-rzg2l: Make fwspec variable as pointer in struct rzg2l_irqc_priv Biju
2026-02-06 11:42 ` Thomas Gleixner
2026-02-24 13:46 ` Biju Das
2026-02-06 11:16 ` [PATCH v3 4/9] irqchip/renesas-rzg2l: Drop IRQC_NUM_IRQ macro Biju
2026-02-06 11:50 ` Thomas Gleixner
2026-02-24 13:49 ` Biju Das
2026-02-06 11:16 ` [PATCH v3 5/9] irqchip/renesas-rzg2l: Drop IRQC_TINT_START macro Biju
2026-02-06 11:16 ` [PATCH v3 6/9] irqchip/renesas-rzg2l: Drop IRQC_IRQ_COUNT macro Biju
2026-02-06 11:16 ` [PATCH v3 7/9] irqchip/renesas-rzg2l: Add RZ/G3L support Biju
2026-02-06 11:58 ` Thomas Gleixner
2026-02-24 13:50 ` Biju Das
2026-02-06 11:16 ` [PATCH v3 8/9] irqchip/renesas-rzg2l: Add shared irq support Biju
2026-02-06 11:16 ` [PATCH v3 9/9] arm64: dts: renesas: r9a08g046: Add ICU node Biju
2026-02-06 11:37 ` [PATCH v3 0/9] Add RZ/G3L IRQC support Thomas Gleixner
2026-02-06 11:49 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY3PR01MB113465DF3134440209DFD94058667A@TY3PR01MB11346.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=biju.das.au@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®