From: Biju Das <biju.das.jz@bp.renesas.com>
To: wsa+renesas <wsa+renesas@sang-engineering.com>
Cc: "biju.das.au" <biju.das.au@gmail.com>,
Ulf Hansson <ulfh@kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH v24 11/15] mmc: renesas_sdhi: Add RZ/G3L SDHI support
Date: Fri, 23 Oct 2026 15:48:55 +0000 [thread overview]
Message-ID: <TY3PR01MB1134664CF97EC057E8B2A952D86642@TY3PR01MB11346.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <atnyAfePwJ_9kenH@shikoro>
Hi Wolfram,
> -----Original Message-----
> From: wsa+renesas <wsa+renesas@sang-engineering.com>
> Sent: 22 October 2026 12:23
> Subject: Re: [PATCH v24 11/15] mmc: renesas_sdhi: Add RZ/G3L SDHI support
>
>
> > > So initially bit 8+9 will have a value. This will be moved to bit 16
> > > + 17 first Then we clear the bits 8 + 9. Bit8(SCLKEN) and
> > > Bit9(SDCLKOFFEN)
>
> Okay, I get it now. Thanks for the explanation.
>
> > > > Does RZG3L have a dedicated naming? I'd guess *_HWADJ1. I wonder
> > > > if it makes sense to have a dedicated define for it. I tend to think so.
> > >
> > > There is no *_HWADJ1 mentioned in HW manual.
> > > Hardware manual mention this register as "SDm_SCC_HWADJ2"
>
> OK.
>
> > >
> > > >
> > > > > + if (hwadj2)
> > > > > + sd_scc_write32(host, priv, RZG3L_SDHI_SCC_HWADJ2, 0x3FFF);
> > > > > + } else {
> > > > > sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_TMPPORT2, 0x1);
> > > > > + if (hwadj2)
> > > > > + sd_scc_write32(host, priv, RZG3L_SDHI_SCC_HWADJ2, 0xFF);
> > > >
> > > > Magic values?
> > >
> > > HW manual mentions the following,
> > >
> > > HWADJ2[15:0] 1FFh Hardware Adjustment.
> > > For 1.8V operation, specify 00FFh.
> > > For 3.3V operation, specify 3FFFh.
> > >
> > > Is the below macros ok for representing magic values??
> > >
> > > SD_SCC_HWADJ2_1_8V 0xFF
> > > SD_SCC_HWADJ2_3_3V 0x3FFF
>
> If you replace the 'SD_'-prefix with 'RZG3L_SDHI_', then yes :)
Agreed.
>
> > > > I wonder how likely it is that a SDHI variant has either only this
> > > > or only TUNING_DELAY. Do you know of one? What would you think
> > > > about merging the two? You know the RZ SDHI
> > > much better...
> > >
> > > HWADJ2 present only on RZ/G3L,
> > > whereas TUNING_DELAY present on both RZ/G2L and RZ/G3L.
>
> Ok, no merging then. Was worth asking.
>
> One more thing I noticed. I think you can drop 'sdhi_quirks_rzg3l' in favor of 'sdhi_quirks_fixed_addr',
> or?
Good catch. Will drop 'sdhi_quirks_rzg3l'.
Cheers,
Biju
next prev parent reply other threads:[~2026-10-23 15:48 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 17:16 [PATCH v24 00/15] Add Renesas RZ/G3L SD/eMMC support Biju
2026-08-20 17:16 ` [PATCH v24 01/15] dt-bindings: mmc: renesas,sdhi: Document RZ/G3L (r9a08g046) SoC Biju
2026-09-02 10:45 ` Wolfram Sang
2026-08-20 17:16 ` [PATCH v24 02/15] mmc: renesas_sdhi: Clean up whitespace and add OF table sentinels Biju
2026-09-02 10:47 ` Wolfram Sang
2026-09-04 6:40 ` Biju Das
2026-09-09 18:46 ` wsa+renesas
2026-08-20 17:16 ` [PATCH v24 03/15] mmc: renesas_sdhi: Add clk_mask field to support flexible clock divider widths Biju
2026-09-02 10:51 ` Wolfram Sang
2026-09-04 10:54 ` Biju Das
2026-09-02 10:54 ` Wolfram Sang
2026-09-04 11:03 ` Biju Das
2026-09-10 21:52 ` wsa+renesas
2026-08-20 17:16 ` [PATCH v24 04/15] mmc: renesas_sdhi: Add max_divider field to support SoC-specific clock ranges Biju
2026-09-02 11:05 ` Wolfram Sang
2026-09-04 12:46 ` Biju Das
2026-09-10 21:56 ` wsa+renesas
2026-09-14 10:37 ` Biju Das
2026-08-20 17:16 ` [PATCH v24 05/15] mmc: renesas_sdhi: Add SDHI_SD_CLK_CTL_DIV1 macro for 1/1 option Biju
2026-09-02 11:06 ` Wolfram Sang
2026-08-20 17:16 ` [PATCH v24 06/15] mmc: renesas_sdhi: Make clock divider mask configurable Biju
2026-09-02 11:09 ` Wolfram Sang
2026-09-04 12:48 ` Biju Das
2026-08-20 17:16 ` [PATCH v24 07/15] mmc: renesas_sdhi: Add tuning delay support for RZ/G2L Biju
2026-09-03 9:30 ` Wolfram Sang
2026-09-04 14:47 ` Biju Das
2026-09-13 17:47 ` wsa+renesas
2026-09-14 10:37 ` Biju Das
2026-09-03 9:34 ` Wolfram Sang
2026-09-04 15:15 ` Biju Das
2026-08-20 17:16 ` [PATCH v24 08/15] mmc: renesas_sdhi: Add TMIO_MMC_INTERNAL_DIVIDER flag Biju
2026-09-03 9:37 ` Wolfram Sang
2026-09-07 6:37 ` Biju Das
2026-10-22 9:03 ` wsa+renesas
2026-10-23 13:27 ` Biju Das
2026-09-03 9:43 ` Wolfram Sang
2026-09-07 7:19 ` Biju Das
2026-09-22 12:36 ` Biju Das
2026-10-22 9:30 ` wsa+renesas
2026-10-23 13:35 ` Biju Das
2026-10-23 16:10 ` wsa+renesas
2026-10-26 14:47 ` Biju Das
2026-08-20 17:16 ` [PATCH v24 09/15] mmc: renesas_sdhi: Add optional axis/axim reset controls Biju
2026-09-03 9:48 ` Wolfram Sang
2026-08-20 17:16 ` [PATCH v24 10/15] mmc: renesas_sdhi: Add write32_hook for CTL_SD_CARD_CLK_CTL register writes Biju
2026-09-03 10:30 ` Wolfram Sang
2026-09-07 8:19 ` Biju Das
2026-10-22 9:58 ` wsa+renesas
2026-09-03 10:32 ` Wolfram Sang
2026-09-07 8:27 ` Biju Das
2026-10-22 10:00 ` wsa+renesas
2026-10-23 14:27 ` Biju Das
2026-08-20 17:16 ` [PATCH v24 11/15] mmc: renesas_sdhi: Add RZ/G3L SDHI support Biju
2026-09-03 12:01 ` Wolfram Sang
2026-09-07 12:53 ` Biju Das
2026-09-22 12:35 ` Biju Das
2026-10-22 11:22 ` wsa+renesas
2026-10-23 15:48 ` Biju Das [this message]
2026-08-20 17:16 ` [PATCH v24 12/15] mmc: renesas_sdhi: Save and restore IOVS across suspend/resume Biju
2026-08-20 17:16 ` [PATCH v24 13/15] mmc: renesas_sdhi: Make HS400 OSEL bit configurable per SoC Biju
2026-08-20 17:16 ` [PATCH v24 14/15] mmc: renesas_sdhi: Add RZ/G3L HS400 support Biju
2026-08-20 17:16 ` [PATCH v24 15/15] mmc: renesas_sdhi: Add HS400 enhanced strobe support for RZ/G3L Biju
2026-09-01 14:52 ` [PATCH v24 00/15] Add Renesas RZ/G3L SD/eMMC support Wolfram Sang
2026-09-03 20:11 ` Wolfram Sang
2026-09-04 2:24 ` Biju Das
2026-09-04 8:00 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY3PR01MB1134664CF97EC057E8B2A952D86642@TY3PR01MB11346.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=biju.das.au@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ulfh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®