mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: kernel test robot <lkp@intel.com>,
	"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: RE: drivers/mmc/host/renesas_sdhi_core.c:951: undefined reference to `rdev_get_drvdata'
Date: Sat, 29 Mar 2025 07:24:12 +0000	[thread overview]
Message-ID: <TY3PR01MB11346D7FE2EC7FA3631C48A0C86A32@TY3PR01MB11346.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <Z-eeiMFsQQNMt2nn@shikoro>

Hi Wolfram,

Thanks for the feedback.

> -----Original Message-----
> From: Wolfram Sang <wsa-dev@sang-engineering.com>
> Sent: 29 March 2025 07:17
> Subject: Re: drivers/mmc/host/renesas_sdhi_core.c:951: undefined reference to `rdev_get_drvdata'
> 
> 
> > CONFIG_REGULATOR is not enabled in arm-randconfig-r111-20250328 that
> > is leading to this build issue.
> >
> > I will send a fix by "select REGULATOR" in config MMC_SDHI
> 
> What about using MMC_SDHI_INTERNAL_DMAC? So we leave out at least older SDHI instances. Ideally, we
> would say "select ... if <family>" but this will easily be missed in updates. Maybe the above is a
> fair compromise.
> Those systems will likely have regulators enabled anyhow.

The changes were done in SDHI core (renesas_sdhi_core.c).

Like this, if a random config in that architecture has CONFIG_REGULATOR undefined
will lead to the same error.

Cheers,
Biju

  reply	other threads:[~2025-03-29  7:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 21:43 kernel test robot
2025-03-29  6:41 ` Biju Das
2025-03-29  7:17   ` Wolfram Sang
2025-03-29  7:24     ` Biju Das [this message]
2025-03-29  7:28       ` Wolfram Sang
2025-03-29  7:37         ` Biju Das
2025-03-29  7:47           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY3PR01MB11346D7FE2EC7FA3631C48A0C86A32@TY3PR01MB11346.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa-dev@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®