From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011062.outbound.protection.outlook.com [52.101.125.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96AC566A; Mon, 8 Jul 2024 05:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.62 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720417623; cv=fail; b=cKkWptJU+CWmCffJGTS0N3oHIYyGL9adGfXJknj0mLZCtmiuC0PkmKbQwp1lrmJ5nNlUnZ5dizkj9JmhZs4XnQrQ61ZIzlOKLgoMNT1wQqX8AQAwZhDhXbaeCizyAkqVytMcv6zctF0BuaKDgXyw8rXgbyfvEPaeNV6CdVAEIHE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720417623; c=relaxed/simple; bh=obhSuJpCr1/jTaCj0UFbi+iAcMClJuXGPAmI6vh6syQ=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=eM2W6Nc9wIW4nfJ0LJoYSEBuUjC9DTx/65q4foj2lUIWuRY7H6vAVclo5sJ4p2CdFFHQSdT/fYplkL1Z8lN4vUKY2uu5xNevhr7zg/W5fYdStaBNz2odo9mnFCIavJkor1neIu978ZH7PusLODR1hZoKMlGyY+9bRK3gz91C/K4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=J1FK+PzN; arc=fail smtp.client-ip=52.101.125.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="J1FK+PzN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EONdQnTEAV3AE5oxz7LF9HNNxtUvxXTYkRAJ+kjnMZEk2RbHCPvzae48QBQgPeAahxgPRjzOTHaKG6QVZGo+fakN/mVxU5vSPMOJVOjj0mfHTyTUb0yOV0MJ3JKCpuQheiejzX2vi1VM7PqEZ3XkZJW4IR9milktUgIjjwh+cFg/ckoKVTSLHqGz7FAq9z/YC0owUBQ3exkGS0cozxHxiKJgji/+sfMywd6IHGobkrdUcj0qtVafTVdNLKdEM2o60zhYRE1+r3SeF5Sb3oj4OgPmjaSobx87Y5m4c7N7aJVIOdfuBLGhiRSsXtcSbDz0G9c08V5YFXlhsLrfo4ikNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yBQOt+Pf5VUf5Z9xiGz6/7rZNhajL0iVorbyF4z6eqU=; b=dAtrVuoAoOx7+TUOSMIZrOZtRPUKE3JfuCvn93sTqzXpL02y5V3bCHagSgMUPraSR2ZaEmIMRuxhnDZjoISvb5h5A//JDJUmBztuHUSzSuL2v6+cTZWdy4eAjPnd1twOwfZeSl/17wrf5iTDuaXfPbNZHEJuFgcpmE5R6YlINapl9KBpDKBu9JhedOWlXjyWNr2QTjOaH8CXPzAlgvaG4qMtFqLvB5rsOhxoMc9ZuhEErdZjL0EbWN6/43LtzljQWJmpqD5VJ7NjuncTmI/n3iM98JnQmbll0RgCVaOfqb2sfzWlwdWYULkbf08cKnn87ihOAU5lWb9oKlu6wzjISQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yBQOt+Pf5VUf5Z9xiGz6/7rZNhajL0iVorbyF4z6eqU=; b=J1FK+PzNH1AQHnWe78hiX2FD1HDWOzUd/a3339HId5eC17AQkbzyVKUhlxV/187BNrX9lnlAO6VIk1oINMwLCZrD0UI3/22GvciXuRLCMuWO4hxgOSpbNfUt4hCe5nE61Krfvz4iu1thpZx1PYJHttlClX/4wkqqRA3uBuL7z2s= Received: from TY3PR01MB11346.jpnprd01.prod.outlook.com (2603:1096:400:3d0::7) by OS3PR01MB5813.jpnprd01.prod.outlook.com (2603:1096:604:c0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.34; Mon, 8 Jul 2024 05:46:56 +0000 Received: from TY3PR01MB11346.jpnprd01.prod.outlook.com ([fe80::86ef:ca98:234d:60e1]) by TY3PR01MB11346.jpnprd01.prod.outlook.com ([fe80::86ef:ca98:234d:60e1%4]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 05:46:56 +0000 From: Biju Das To: Claudiu.Beznea , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" CC: "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Claudiu Beznea Subject: RE: [PATCH v9 3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Thread-Topic: [PATCH v9 3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Thread-Index: AQHasyfd9vnzWl5dOEmcSeWB9khhq7HsjeMg Date: Mon, 8 Jul 2024 05:46:56 +0000 Message-ID: References: <20240531065723.1085423-1-claudiu.beznea.uj@bp.renesas.com> <20240531065723.1085423-4-claudiu.beznea.uj@bp.renesas.com> In-Reply-To: <20240531065723.1085423-4-claudiu.beznea.uj@bp.renesas.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY3PR01MB11346:EE_|OS3PR01MB5813:EE_ x-ms-office365-filtering-correlation-id: c0d4da63-dc84-40cf-8033-08dc9f1160a7 x-ld-processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?NgaeBMw9YWtEyrD04YtzEuxztUXRUWh1YySqdpZctj2tzdCrANw72sT42DHn?= =?us-ascii?Q?L3dUzJjlTDKJ0/1oAEc3JzeHOrTbyEle99HL8dh5XsQgG5rTbZrgjeUu5DZz?= =?us-ascii?Q?Xbh6rHyNkqs3CSQOzS2mkfIOiRD9lszUPOZb6Zh+3AoeZzEIpsMnMi/QR6WK?= =?us-ascii?Q?XbuEoFCaMm5usB+m+gkh4MxvGYciaCsgHr2m65Whlgf2eBeOhgT5VlAYTQ1O?= =?us-ascii?Q?JQsKVj6KtDXMw32zg9ZXCoPqwbeo7CQoCc7DJX9Mm5/swVNvLbJxAz5ad0g2?= =?us-ascii?Q?RR/r0qK5ffbYdcMKg6alLJVVRvYK9G/SwYh+hldQuJUFepNrr56ckfgsf08L?= =?us-ascii?Q?LIYzBiBTdeX6s4EieIvklf6ouRkzaWSgVBXCJLFVbzlN5MPMVRTQ9ftKN0KH?= =?us-ascii?Q?1GVZY+sB4hnh4hDji4uwU0Kcqsn9Mb6JEyfQTH2OVotDssR1XtKxy7zzYpzf?= =?us-ascii?Q?oicvqPB5UQzn76NYmWppKW+MxqygXF4JAl9aE+ZOlJs9Psu9Tnn0BAYu4D2+?= =?us-ascii?Q?01vKXlPls8x1NU6bIWZ0u37NhXw2VDHBSxP4VIsRomXBMrLVMbRvloLmL8/9?= =?us-ascii?Q?In+W8IbnJvYhahE1FK5Il9zgrJ6OVUI0fqDrTd0hYTDZHhnUKWpKeyGujVMj?= =?us-ascii?Q?ZohBficW27U5aEXsaQxUn5KLomD0EAClx2UcrHKfPM9if+ljYS2y1xya2pdN?= =?us-ascii?Q?KYo9dA4QNdzKl0V0TKI+qEsVCjNeDYyXIeUyysqbbEbhO+Nfj8INFBR76qJU?= =?us-ascii?Q?h+oyQNfS6HixRP1l9VU+rdGAaTjGzvzlbwe+mRnTgL+4NwMRIbj+sJT6YJBT?= =?us-ascii?Q?xwIE8ONOoe3j6H9GcAHq9d0yt2P8oQl+Vw6zZ8kmCV+L1JVkPgqTBgaLtAxy?= =?us-ascii?Q?b5zxlWjrW5FdoIlljt6hEhy5OumDgd1eyXcEYg4j1cfO5J1Z1nGFJANme/rF?= =?us-ascii?Q?CUM0M5vPZP0/9EP0/65eynOOwOKXjvqBkrc5qkvbgFz4xMOMrynuWcpFo3GA?= =?us-ascii?Q?kfPh+Fp865xVim9KzavsnzdLjW0TUn66HUCOKY+5DZBRov2lhQDbbCBWppYi?= =?us-ascii?Q?UR9WSBhqyWe2W/5tV/DSqwfe8Zljep9L0iyrFAPqOZDd26juc3jEPg+WirvZ?= =?us-ascii?Q?tuIrvUhHJTNKBxgjctLuLQXaihEK53+pbd0XgGVp5bEvIO35MnQ3xZVJtvpO?= =?us-ascii?Q?BrsUIRyfVhvu1L2QQqPr6MGGmmxXYYw+cSYYTcKcaDPTLGSVyR7Ew1Pf414x?= =?us-ascii?Q?Hu6ISV46uOPCXih4cyORrJM8czU/z7jOWWudE8m1QP8RgiL93NpQoQ/6+Gul?= =?us-ascii?Q?ilIYq2nh4kYYsMAYnGPGAbpb2KunZhAJJprkNzCK0x4RnnouETT/SWF9pGSe?= =?us-ascii?Q?zQAjw90=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY3PR01MB11346.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hmJ0kxPBkEwPIJTpw0uPeCtbEQ8LjnRL/C7J5kVyt3NXoj8E7JODdq3Zl6hE?= =?us-ascii?Q?xgcOAiQlOhC2EadAb4p+uTOk/oXcJQzufrtEZ4ec7Y0LZ4DEod57K6QQzx1T?= =?us-ascii?Q?RzEJkIweoWd5KSPwD5kQCx7kbuwj499fOkQOujeNcK7nFFL0ShR7gg1mjoMI?= =?us-ascii?Q?mkVQO5lfXE+RKlA883403kSPM89KQiQZY3lw+ihBpBrsbsZUI6p+Okdijhva?= =?us-ascii?Q?Elw8VyJC9K376vXXiFPD5Cze2s9EaIAyHFqT7mSg8L/Dog8aD1cihjGVFgYT?= =?us-ascii?Q?g9rVIPrs+/3YKh0iPMH8tH3OhOggkeekNVwWrWRIpPihq8kfkDFlmeOvF/TN?= =?us-ascii?Q?0TTU7dkjxBogW8qCnoVAA1PsUausm+aMTU8qUYabxQKbm2b0mS0Ti6D3x/DX?= =?us-ascii?Q?Pjce9Vx/LcW0j72Lqf5bGtVBFalX2UQyCvbbEEGPUmUAfptwBvJ2sQgULik2?= =?us-ascii?Q?aDuKMSj0KIKss5AGzkwVziKSQMv6hpyNvIuFkR74u4V23yWFFGrDLMk+xeLX?= =?us-ascii?Q?sglGNp9n9eMoaVRCoul71NHjm6GSJMD9gr2Witl/OiV0V3a9mAQsLvg/LWEn?= =?us-ascii?Q?cUedrYQGX6AlmZNM4/z07nTfKbEoZ2sqHSkXJ6KRHoes7ZsXjPbW0+k5wRMv?= =?us-ascii?Q?KTvpde9xKsDkRvvFqfQi2pCDaqEE2NCrCz52Wbb976YV+vliOQLeyDuTXzks?= =?us-ascii?Q?moHChK75uNLWgRFTwaY65Jh918t5HUrC/kYq8iQLwlEJ6amkGcRyH7UVWtpH?= =?us-ascii?Q?gJTZOVW3OhE3skgrDwvQfvopVbslwvpBPFHV/xml7m0cE0jqZoWhT9QNqqFp?= =?us-ascii?Q?2JUSRkzT/bHYsECJ3KWysLm2qGAwM0VXbeVOdhpSrFODtWqO9kLJ1p/kPCp2?= =?us-ascii?Q?c8LG6wKVZvXiZfc72bs37bOeiK346bkEixTLFpLuofhaTe5RAbImMxZRbdQt?= =?us-ascii?Q?JHLo9JFo76l7MzdXxyRaYMF5bFXiAOvJGlAPRkjn7nN0qIs827PG8EZBUTu0?= =?us-ascii?Q?/dge9R7rfyc5NaLHo6UPK93LWaERR+fCFEivxB4+Gm2AFjmYc+gce+uCiMG9?= =?us-ascii?Q?8n1jTaXtjuZZ/xOLeZoqZflv8sEmsHcylfJEPKGM35EPolPqFt1yxBLV5F+v?= =?us-ascii?Q?/De1b5l+GqvVFK8lIpCeTBaqVFaaiLuRuqsaMvcsUXTlzFZojoFKPgpXNsuS?= =?us-ascii?Q?GkBhTtzfDPtcqG9FfoIC1yCMAXA2YgJaNXcOJASMbijC+n5DvBuMnnqFi6ti?= =?us-ascii?Q?qQNeW7gOD4cQbvGMdRSC0Eo84bb8+X8QpGAc/wHHrEaapyp0bVc9U5eTiEls?= =?us-ascii?Q?2UY+t8qyHZBbd4R+M/WQahFY1sQMmJJe3XKn3H6t321GErkcn5cSgxJSePT0?= =?us-ascii?Q?MboYGIPgd4AN/wWHFrd/+sq/xFn92VaX2Mcr1z7eg726yJa51pPsBEyrVJde?= =?us-ascii?Q?5vTWJv4RuvW7mslQKhRhoVnuaHKZ3VtiZPJn9lxXbTXp2BxuvIlCERvnSGwU?= =?us-ascii?Q?5zNd9R5zOjiP7YEQmRA+KoekXp7TT9AQSVi80oj0zRX9FlMNRE5UZuqX66K8?= =?us-ascii?Q?DiCE6plUdJFan7WkHjiKMct1e0G1Lw5Yl1+pBe45u+6C8shxn6cnxa/wVngz?= =?us-ascii?Q?og=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY3PR01MB11346.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0d4da63-dc84-40cf-8033-08dc9f1160a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2024 05:46:56.4383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DCa/B5PGfsuyor3B5PiGJTRDZTFbNs/idRivWfkr5GpXxTOcYD/PsEbFe6+gfGlP9twZl1ULa9RoZg+44AY96DhVNz6wjt7KXcgfJemzbm8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB5813 Hi Claudiu, > -----Original Message----- > From: Claudiu > Sent: Friday, May 31, 2024 7:57 AM > Subject: [PATCH v9 3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_ge= t() >=20 > From: Claudiu Beznea >=20 > pm_runtime_get_sync() may return with error. In case it returns with erro= r > dev->power.usage_count needs to be decremented. > dev->pm_runtime_resume_and_get() > takes care of this. Thus use it. >=20 > Along with it the rzg2l_wdt_set_timeout() function was updated to propaga= te the result of > rzg2l_wdt_start() to its caller. >=20 > Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L") > Signed-off-by: Claudiu Beznea > Reviewed-by: Guenter Roeck > --- >=20 > Changes in v9: > - collected Guenter's Rb tag >=20 > Changes in v8: > - none >=20 > Changes in v7: > - none >=20 > Changes in v6: > - none >=20 > Changes in v5: > - none >=20 > Changes in v4: > - none >=20 > Changes in v3: > - none >=20 > Changes in v2: > - propagate the return code of rzg2l_wdt_start() to it's callers >=20 >=20 > drivers/watchdog/rzg2l_wdt.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c = index > 1741f98ca67c..d87d4f50180c 100644 > --- a/drivers/watchdog/rzg2l_wdt.c > +++ b/drivers/watchdog/rzg2l_wdt.c > @@ -123,8 +123,11 @@ static void rzg2l_wdt_init_timeout(struct watchdog_d= evice *wdev) static int > rzg2l_wdt_start(struct watchdog_device *wdev) { > struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev); > + int ret; >=20 > - pm_runtime_get_sync(wdev->parent); > + ret =3D pm_runtime_resume_and_get(wdev->parent); > + if (ret) > + return ret; Checking ret will lead to imbalance. It should be ret < 0 as ret =3D 1 corr= esponds to RPM_ACTIVE and the API does not call put() when ret =3D 1; see [= 1] and [2] [1] https://elixir.bootlin.com/linux/v6.10-rc6/source/drivers/base/power/ru= ntime.c#L778 [2] https://elixir.bootlin.com/linux/v6.10-rc6/source/include/linux/pm_runt= ime.h#L431 Cheers, Biju