mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <yuji2.ishikawa@toshiba.co.jp>
To: <Frank.li@nxp.com>
Cc: <nobuhiro.iwamatsu.x90@mail.toshiba>, <mchehab@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<p.zabel@pengutronix.de>, <linux-media@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver
Date: Mon, 20 Oct 2025 06:11:52 +0000	[thread overview]
Message-ID: <TY3PR01MB99823396DFFF60DCF661011192F5A@TY3PR01MB9982.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <aPB16VqrMZrMNDSq@lizhi-Precision-Tower-5810>

Hello Frank

Thank you for review comments.

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Thursday, October 16, 2025 1:35 PM
> To: ishikawa yuji(石川 悠司 □AIDC○EA開)
> <yuji2.ishikawa@toshiba.co.jp>
> Cc: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT)
> <nobuhiro.iwamatsu.x90@mail.toshiba>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Philipp Zabel
> <p.zabel@pengutronix.de>; linux-media@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add
> Toshiba Visconti MIPI CSI-2 Receiver
> 
> On Thu, Oct 16, 2025 at 11:24:38AM +0900, Yuji Ishikawa wrote:
> > Adds the Device Tree binding documentation that allows to describe the
> > MIPI CSI-2 Receiver found in Toshiba Visconti SoCs.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> > ---
> > Changelog v12:
> > - Newly add bindings for CSI2RX driver
> >
> > Changelog v13:
> > - add entries to MAINTAINERS file.
> > - update email address of Nobuhiro Iwamatsu in /maintainers
> > - add Yuji Ishikawa to /maintainers
> > - change /properties/compatible: toshiba,visconti5-csi2rx ->
> > toshiba,visconti5-csi2
> > - change bindings file name: toshiba,visconti5-csi2rx ->
> > toshiba,visconti5-csi2
> > - change node name in sample DTS: csi2rx -> csi
> > - remove "|-" from /description
> > - update /description
> > - add definitions of clock and reset
> > - update /properties/ports/properties/port@0/description for better
> > comment
> > - update /properties/ports/properties/port@0/$ref to specify full
> > pathname
> > - remove
> /properties/ports/properties/port@0/properties/endpoint/properties/data-la
> nes/description because the default text provides enough information.
> > - update sample dts
> > ---
> >  .../bindings/media/toshiba,visconti5-csi2.yaml     | 125
> +++++++++++++++++++++
> >  MAINTAINERS                                        |   7 ++
> >  2 files changed, 132 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.yaml
> > b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.yaml
> > new file mode 100644
> > index 000000000000..21fb46de5b6e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.y
> > +++ aml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/toshiba,visconti5-csi2.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver
> > +
> > +maintainers:
> > +  - Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>
> > +  - Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> > +
> > +description:
> > +  Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI
> > +CSI-2 video
> > +  stream. The obtained video stream is used as input for the Visconti5 VIIF.
> > +
> > +properties:
> > +  compatible:
> > +    const: toshiba,visconti5-csi2
> > +
> 
> ...
> 
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        csi0: csi@1c008000 {
> 
> Needn't label csi0
> 

I'll drop the label.

> > +            compatible = "toshiba,visconti5-csi2";
> > +            reg = <0 0x1c008000 0 0x400>;
> > +            interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > +            clocks = <&pismu TMPV770X_CLK_VIIFBS0_CFG>,
> > +                     <&pismu TMPV770X_CLK_VIIFBS0_APB>;
> > +            clock-names = "cfg", "apb";
> > +            resets = <&pismu TMPV770X_RESET_VIIFBS0_APB>;
> > +
> > +            ports {
> > +                #address-cells = <1>;
> > +                #size-cells = <0>;
> 
> need empty line here.

I'll add empty line before blocks.

> > +                port@0 {
> > +                    reg = <0>;
> 
> empty line here
> 
> > +                    csi0_in: endpoint {
> > +                        data-lanes = <1 2>;
> > +                        remote-endpoint = <&imx219_out>;
> > +                    };
> > +                };
> 
> empty line here
> 
> Frank
> > +                port@1 {
> > +                    reg = <1>;
> > +                    csi0_out: endpoint {
> > +                        remote-endpoint = <&video0_in>;
> > +                    };
> > +                };
> > +            };
> > +        };
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 46126ce2f968..e4634a0aad74 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -25979,6 +25979,13 @@ F:
> 	Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.txt
> >  F:	drivers/media/i2c/tc358743*
> >  F:	include/media/i2c/tc358743.h
> >
> > +TOSHIBA VISCONTI VIIF DRIVER
> > +M:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>
> > +M:	Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> > +L:	linux-media@vger.kernel.org
> > +S:	Maintained
> > +F:
> 	Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.ya
> ml
> > +
> >  TOSHIBA WMI HOTKEYS DRIVER
> >  M:	Azael Avalos <coproscefalo@gmail.com>
> >  L:	platform-driver-x86@vger.kernel.org
> >
> > --
> > 2.34.1
> >
> >

Regards,

Yuji Ishikawa


  reply	other threads:[~2025-10-20  6:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  2:24 [PATCH v13 0/7] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2025-10-16  2:24 ` [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver Yuji Ishikawa
2025-10-16  4:34   ` Frank Li
2025-10-20  6:11     ` yuji2.ishikawa [this message]
2025-10-16  6:38   ` Krzysztof Kozlowski
2025-10-20  6:16     ` yuji2.ishikawa
2025-10-16  2:24 ` [PATCH v13 2/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Yuji Ishikawa
2025-10-16  6:39   ` Krzysztof Kozlowski
2025-10-16  2:24 ` [PATCH v13 3/7] media: uapi: Add visconti viif meta buffer formats Yuji Ishikawa
2025-10-16  2:24 ` [PATCH v13 4/7] media: platform: visconti: Add Toshiba Visconti CSI-2 Receiver driver Yuji Ishikawa
2025-10-16  4:45   ` Frank Li
2025-10-20  6:13     ` yuji2.ishikawa
2025-10-20 16:05       ` Frank Li
2025-10-16  2:24 ` [PATCH v13 5/7] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2025-10-16  2:24 ` [PATCH v13 6/7] media: platform: visconti: Add streaming interface for ISP parameters and statistics Yuji Ishikawa
2025-10-16  2:24 ` [PATCH v13 7/7] documentation: media: Add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY3PR01MB99823396DFFF60DCF661011192F5A@TY3PR01MB9982.jpnprd01.prod.outlook.com \
    --to=yuji2.ishikawa@toshiba.co.jp \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nobuhiro.iwamatsu.x90@mail.toshiba \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®