mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Dege <michael.dege@renesas.com>
To: Jiawen Liu <1298662399@qq.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: RE: [PATCH] net: renesas: rswitch-main: fix runtime PM cleanup
Date: Tue, 18 Aug 2026 13:01:54 +0000	[thread overview]
Message-ID: <TY4PR01MB142827F5B7F90EB74FE33CB8382A62@TY4PR01MB14282.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <tencent_2EBD0396FF7A54CAD61F16E942D2E8FA3A0A@qq.com>

Hi Jiawen,

Thank you for your patch.

> -----Original Message-----
> From: Jiawen Liu <1298662399@qq.com>
> Sent: Tuesday, August 18, 2026 2:42 PM
> To: Andrew Lunn <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>;
> netdev@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>; jiawen <1298662399@qq.com>
> Subject: [PATCH] net: renesas: rswitch-main: fix runtime PM cleanup
> 
> [You don't often get email from 1298662399@qq.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: jiawen <1298662399@qq.com>
> 
> Update renesas_eth_sw_probe() for the confirmed driver lifecycle defect.
> 
> Keep the change limited to the concrete operation shown in the final patch.
> 
> Signed-off-by: jiawen <1298662399@qq.com>

Reviewed-by: Michael Dege <Michael.dege@renesas.com >

> ---
> diff --git a/drivers/net/ethernet/renesas/rswitch_main.c b/drivers/net/ethernet/renesas/rswitch_main.c
> --- a/drivers/net/ethernet/renesas/rswitch_main.c
> +++ b/drivers/net/ethernet/renesas/rswitch_main.c
> @@ -2123,6 +2123,8 @@
>         { /* Sentinel */ }
>  };
> 
> +static void rswitch_deinit(struct rswitch_private *priv);
> +
>  static int renesas_eth_sw_probe(struct platform_device *pdev)  {
>         const struct soc_device_attribute *attr; @@ -2194,6 +2196,9 @@
>         ret = rswitch_register_notifiers();
>         if (ret) {
>                 dev_err(&pdev->dev, "could not register notifiers\n");
> +               rswitch_deinit(priv);
> +               pm_runtime_put(&pdev->dev);
> +               pm_runtime_disable(&pdev->dev);
>                 return ret;
>         }
> 
> 


  reply	other threads:[~2026-08-18 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 12:41 Jiawen Liu
2026-08-18 13:01 ` Michael Dege [this message]
2026-08-18 13:06 ` Geert Uytterhoeven
2026-08-18 15:00 ` Andrew Lunn
2026-11-08 17:22   ` Jiawen Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY4PR01MB142827F5B7F90EB74FE33CB8382A62@TY4PR01MB14282.jpnprd01.prod.outlook.com \
    --to=michael.dege@renesas.com \
    --cc=1298662399@qq.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®