mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Dege <michael.dege@renesas.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	niklas.soderlund <niklas.soderlund@ragnatech.se>,
	Paul Barker <paul@pbarker.dev>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v4 05/13] net: renesas: rswitch: add exception path for packets with unknown dst MAC
Date: Fri, 22 May 2026 10:47:14 +0000	[thread overview]
Message-ID: <TY4PR01MB14282ABE2BE7EF7114DCCDDB5820F2@TY4PR01MB14282.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20260512183716.482f3f90@kernel.org>

Hello Jakub,

Thank you very much for your review.

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, May 13, 2026 3:37 AM
> To: Michael Dege <michael.dege@renesas.com>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>; Andrew Lunn <andrew+netdev@lunn.ch>; David
> S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>;
> niklas.soderlund <niklas.soderlund@ragnatech.se>; Paul Barker <paul@pbarker.dev>;
> netdev@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v4 05/13] net: renesas: rswitch: add exception path for packets with
> unknown dst MAC
> 
> On Mon, 11 May 2026 10:52:08 +0200 Michael Dege wrote:
> > Packets with unknown MAC address cannot be handled by the HW forwarding.
> > These need to be forwarded, via an exception path, to the network driver.
> >
> > Creates a queue for the exeption path. Packets received with unknown
> > src/dst address need to be passed to the CPU. The received packet does
> > not have the correct source port information, this is derived from the
> > descriptor and added to the new queue. The received packet is added to
> > the new queue and sent to the CPU for MAC learning. The CPU will
> > broadcast the received packet, to all ports. This is how the HW learns
> > the new MAC address.
> 
> I sent the AI reviews out just in case, main reason I'm dropping this from pw is the new sparse build
> warning here:

The AI reviews have been very helpful for the most part.
> 
> drivers/net/ethernet/renesas/rswitch_main.c:1015:23: warning: cast to restricted __le64
> drivers/net/ethernet/renesas/rswitch_main.c:1015:23: warning: restricted __le64 degrades to integer
> drivers/net/ethernet/renesas/rswitch_main.c:1015:23: warning: restricted __le64 degrades to integer

This is now fixed.

Best regards,

Michael

  reply	other threads:[~2026-05-22 10:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  8:52 [net-next PATCH v4 00/13] net: renesas: rswitch: R-Car S4 add VLAN aware switching Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 01/13] net: renesas: rswitch: improve port change mode functions Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 02/13] net: renesas: rswitch: use device instead of net_device Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 12:10     ` Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 03/13] net: renesas: rswitch: fix FWPC2 register access macros Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 04/13] net: renesas: rswitch: add register definitions for vlan support Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 05/13] net: renesas: rswitch: add exception path for packets with unknown dst MAC Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 12:07     ` Michael Dege
2026-05-13  1:37   ` Jakub Kicinski
2026-05-22 10:47     ` Michael Dege [this message]
2026-05-11  8:52 ` [PATCH net-next v4 06/13] net: renesas: rswitch: add forwarding rules for gwca Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 07/13] net: renesas: rswitch: make helper functions available to whole driver Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 11:53     ` Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 08/13] net: renesas: rswitch: add basic vlan init to rswitch_fwd_init Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 09/13] net: renesas: rswitch: update port HW init Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 11:51     ` Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 10/13] net: renesas: rswitch: clean up is_rdev rswitch_device checking Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 11:14     ` Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 11/13] net: renesas: rswitch: add passing of rswitch_private into notifiers Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 11:16     ` Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 12/13] net: renesas: rswitch: add handler for FDB notification Michael Dege
2026-05-13  1:35   ` Jakub Kicinski
2026-05-22 11:02     ` Michael Dege
2026-05-11  8:52 ` [PATCH net-next v4 13/13] net: renesas: rswitch: add vlan aware switching Michael Dege

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY4PR01MB14282ABE2BE7EF7114DCCDDB5820F2@TY4PR01MB14282.jpnprd01.prod.outlook.com \
    --to=michael.dege@renesas.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=pabeni@redhat.com \
    --cc=paul@pbarker.dev \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®