From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Simon Horman <horms@verge.net.au>
Cc: "kishon@ti.com" <kishon@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 3/3] phy: renesas: rcar-gen3-usb2: enable/disable independent irqs
Date: Tue, 9 Apr 2019 09:47:49 +0000 [thread overview]
Message-ID: <TYAPR01MB4271AF6C14F4A99902FAFA2FD82D0@TYAPR01MB4271.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190403091939.qguys2dftombenpb@verge.net.au>
Hi Simon-san,
> From: Simon Horman, Sent: Wednesday, April 3, 2019 6:20 PM
>
> Hi Shimoda-san,
>
> On Mon, Apr 01, 2019 at 09:01:23PM +0900, Yoshihiro Shimoda wrote:
> > Since the previous code enabled/disabled the irqs both OHCI and EHCI,
> > it is possible to cause unexpected interruptions. To avoid this,
> > this patch creates multiple phy instances from phandle and
> > enables/disables independent irqs by the instances.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> I noted a few nits below but overall this looks good to me.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thank you for your review!
<snip>
> > +#define NUM_OF_PHYS 4
> > +#define PHY_INDEX_BOTH_HC 0
> > +#define PHY_INDEX_OHCI 1
> > +#define PHY_INDEX_EHCI 2
> > +#define PHY_INDEX_HSUSB 3
>
> nit: I think the above #defines would be better expressed as an enum.
I'll modify it.
<snip>
> > +static enum usb_dr_mode rcar_gen3_get_dr_mode(struct device_node *np)
> > +{
> > + enum usb_dr_mode candidate = USB_DR_MODE_UNKNOWN, tmp;
>
> nit: I think that there could be a better name for tmp, f.e. mode
> nit: The scope of tmp could be limited to inside the for loop.
I'll modify it.
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-04-09 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 12:01 [PATCH 0/3] " Yoshihiro Shimoda
2019-04-01 12:01 ` [PATCH 1/3] dt-bindings: phy: rcar-gen3-phy-usb2: Revise #phy-cells property Yoshihiro Shimoda
2019-04-03 9:20 ` Simon Horman
2019-04-08 6:13 ` Yoshihiro Shimoda
2019-04-03 10:35 ` Fabrizio Castro
2019-04-08 6:22 ` Yoshihiro Shimoda
2019-04-01 12:01 ` [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Use pdev's device pointer on dev_vdbg() Yoshihiro Shimoda
2019-04-03 9:21 ` Simon Horman
2019-04-03 10:36 ` Fabrizio Castro
2019-04-01 12:01 ` [PATCH 3/3] phy: renesas: rcar-gen3-usb2: enable/disable independent irqs Yoshihiro Shimoda
2019-04-03 9:19 ` Simon Horman
2019-04-09 9:47 ` Yoshihiro Shimoda [this message]
2019-04-03 10:49 ` Fabrizio Castro
2019-04-09 9:49 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4271AF6C14F4A99902FAFA2FD82D0@TYAPR01MB4271.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®