From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
"linux-kernel@lists.codethink.co.uk"
<linux-kernel@lists.codethink.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms+renesas@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: renesas_usbhs: fix __le16 warnings
Date: Wed, 16 Oct 2019 02:35:07 +0000 [thread overview]
Message-ID: <TYAPR01MB4544032F002C7B28E2ED5A19D8920@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191015155044.11858-1-ben.dooks@codethink.co.uk>
Hi Ben,
> From: Ben Dooks (Codethink), Sent: Wednesday, October 16, 2019 12:51 AM
>
> Fix the warnings generated by casting to/from __le16 without
> using the correct functions.
>
> Fixes the following sparse warnings:
>
> drivers/usb/renesas_usbhs/common.c:165:25: warning: incorrect type in assignment (different base types)
> drivers/usb/renesas_usbhs/common.c:165:25: expected restricted __le16 [usertype] wValue
> drivers/usb/renesas_usbhs/common.c:165:25: got unsigned short
> drivers/usb/renesas_usbhs/common.c:166:25: warning: incorrect type in assignment (different base types)
> drivers/usb/renesas_usbhs/common.c:166:25: expected restricted __le16 [usertype] wIndex
> drivers/usb/renesas_usbhs/common.c:166:25: got unsigned short
> drivers/usb/renesas_usbhs/common.c:167:25: warning: incorrect type in assignment (different base types)
> drivers/usb/renesas_usbhs/common.c:167:25: expected restricted __le16 [usertype] wLength
> drivers/usb/renesas_usbhs/common.c:167:25: got unsigned short
> drivers/usb/renesas_usbhs/common.c:173:39: warning: incorrect type in argument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:173:39: expected unsigned short [usertype] data
> drivers/usb/renesas_usbhs/common.c:173:39: got restricted __le16 [usertype] wValue
> drivers/usb/renesas_usbhs/common.c:174:39: warning: incorrect type in argument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:174:39: expected unsigned short [usertype] data
> drivers/usb/renesas_usbhs/common.c:174:39: got restricted __le16 [usertype] wIndex
> drivers/usb/renesas_usbhs/common.c:175:39: warning: incorrect type in argument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:175:39: expected unsigned short [usertype] data
>
> Note. I belive this to be correct, and should be a no-op on arm.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-10-16 2:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:50 Ben Dooks (Codethink)
2019-10-15 16:45 ` Geert Uytterhoeven
2019-10-16 2:35 ` Yoshihiro Shimoda [this message]
2019-10-16 12:26 ` Simon Horman
2019-10-17 2:18 ` Yoshihiro Shimoda
2019-10-17 6:57 ` Geert Uytterhoeven
2019-10-17 10:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544032F002C7B28E2ED5A19D8920@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=ben.dooks@codethink.co.uk \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®