mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
	"linux-kernel@lists.codethink.co.uk" 
	<linux-kernel@lists.codethink.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: renesas_usbhs: fix type of buf
Date: Wed, 16 Oct 2019 02:33:52 +0000	[thread overview]
Message-ID: <TYAPR01MB45444200737D0CAB2DC7873FD8920@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191015153017.10858-1-ben.dooks@codethink.co.uk>

Hi Ben,

> From: Ben Dooks (Codethink), Sent: Wednesday, October 16, 2019 12:30 AM
> 
> Fix the type of buf in __usbhsg_recip_send_status to
> be __le16 to avoid the following sparse warning:
> 
> drivers/usb/renesas_usbhs/mod_gadget.c:335:14: warning: incorrect type in assignment (different base types)
> drivers/usb/renesas_usbhs/mod_gadget.c:335:14:    expected unsigned short
> drivers/usb/renesas_usbhs/mod_gadget.c:335:14:    got restricted __le16 [usertype]
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

I also found a parse warning in the usbhsg_recip_handler_std_set_device().
So, I'll make a patch to fix the warning.

Best regards,
Yoshihiro Shimoda


      reply	other threads:[~2019-10-16  2:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 15:30 Ben Dooks (Codethink)
2019-10-16  2:33 ` Yoshihiro Shimoda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB45444200737D0CAB2DC7873FD8920@TYAPR01MB4544.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®