RE: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings

[<yuji2.ishikawa@toshiba.co.jp>]

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, January 12, 2023 5:11 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>; hverkuil@xs4all.nl;
> laurent.pinchart@ideasonboard.com; mchehab@kernel.org; iwamatsu
> nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: linux-media@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba
> Visconti Video Input Interface bindings
> 
> On 12/01/2023 03:05, yuji2.ishikawa@toshiba.co.jp wrote:
> >>>> Compatible must be specific. You called your SoC visconti5, didn't you?
> >>>>
> >>>
> >>> The Video Input Interface hardware is likely to be used at future
> >>> SoCs of Visconti Architecture.
> >>> Does compatible have to be specific to SoC's model name rather than
> >>> architecture name?
> >>
> >> Compatibles should always be specific to SoC model name. Adding more
> >> generic family fallback is also good idea when it is applicable.
> >>
> >
> > I'll update the compatible to "toshiba,visconti5-viif".
> > I'll consider adding generic version "toshiba,visconti-viif" when a successor
> SoC gets available.
> 
> Are you sure? You will have to wait at least one cycle between DTS and driver
> change, due to ABI break of DTB users.

Thank you for the advice. I've come to understand the risk.
I would still use only "toshiba,visconti5-viif",
because there's enough time for internal evaluation before product release.
I can work on DTS and driver change with that time.

> 
> Best regards,
> Krzysztof

Regards,
Yuji