mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>
To: "'Ilpo Järvinen'" <ilpo.jarvinen@linux.intel.com>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"Reinette Chatre" <reinette.chatre@intel.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Fenghua Yu" <fenghua.yu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 00/19] selftests/resctrl: Fixes and cleanups
Date: Mon, 12 Jun 2023 06:02:09 +0000	[thread overview]
Message-ID: <TYAPR01MB633029B8CEAEEFE28197A2458B54A@TYAPR01MB6330.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230605180145.112924-1-ilpo.jarvinen@linux.intel.com>

Hi Ilpo,

> Here is a series with some fixes and cleanups to resctrl selftests. In v3, the
> rewritten CAT test is not included as an issue was discovered in one of its
> components requiring further work before it can be included to mainline.
> 
> v3:
> - Don't include rewritten CAT test into this series!
> - Tweak wildcard style in Makefile
> - Fix many changelog typos, remove some wrong claims, and generally
>   improve them.
> - Add fix to PARENT_EXIT() to unmount resctrl FS
> - Add unmounting resctrl FS before starting any tests
> - Add fix for buf leak
> - Add fix for perf fd closing
> - Split mount/remount/umount patches differently
> - Use size_t and %zu for span
> - Keep MBM print as MB, only internally use span in bytes
> - Drop start_buf global from fill_buf

I reviewed this patch series,
and ran resctrl selftest on Intel(R) Xeon(R) Gold 6254 CPU,
it seems there is no problem.

<Tested-by:tan.shaopeng@jp.fujitsu.com>
<Reviewed-by:tan.shaopeng@jp.fujitsu.com>

      parent reply	other threads:[~2023-06-12  6:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 18:01 Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 01/19] selftests/resctrl: Add resctrl.h into build deps Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 02/19] selftests/resctrl: Don't leak buffer in fill_cache() Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 03/19] selftests/resctrl: Unmount resctrl FS if child fails to run benchmark Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 04/19] selftests/resctrl: Close perf value read fd on errors Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 05/19] selftests/resctrl: Unmount resctrl FS before starting the first test Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 06/19] selftests/resctrl: Move resctrl FS mount/umount to higher level Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 07/19] selftests/resctrl: Refactor remount_resctrl(bool mum_resctrlfs) to mount_resctrl() Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 08/19] selftests/resctrl: Remove mum_resctrlfs from struct resctrl_val_param Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 09/19] selftests/resctrl: Convert span to size_t Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 10/19] selftests/resctrl: Express span internally in bytes Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 11/19] selftests/resctrl: Remove duplicated preparation for span arg Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 12/19] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill_buf() Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 13/19] selftests/resctrl: Remove unnecessary startptr global from fill_buf Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 14/19] selftests/resctrl: Improve parameter consistency in fill_buf Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 15/19] selftests/resctrl: Don't pass test name to fill_buf Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 16/19] selftests/resctrl: Don't use variable argument list for ->setup() Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 17/19] selftests/resctrl: Move CAT/CMT test global vars to function they are used in Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 18/19] selftests/resctrl: Pass the real number of tests to show_cache_info() Ilpo Järvinen
2023-06-05 18:01 ` [PATCH v3 19/19] selftests/resctrl: Remove test type checks from cat_val() Ilpo Järvinen
2023-06-12  6:02 ` Shaopeng Tan (Fujitsu) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB633029B8CEAEEFE28197A2458B54A@TYAPR01MB6330.jpnprd01.prod.outlook.com \
    --to=tan.shaopeng@fujitsu.com \
    --cc=fenghua.yu@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®