From: Shiji Yang <yangshiji66@outlook.com>
To: jonas.gorski@gmail.com
Cc: albeu@free.fr, brgl@bgdev.pl, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: ath79: convert to dynamic GPIO base allocation
Date: Wed, 26 Jun 2024 08:42:24 +0800 [thread overview]
Message-ID: <TYCP286MB0895E5D272723AB55F9F4043BCD62@TYCP286MB0895.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAOiHx==oBMZiVaZ_ra0ren-sea+D4znXQA8wq-dA+5sC0dav5w@mail.gmail.com>
On 2024-06-25 14:16 UTC, Jonas Gorski wrote:
>
>> - /* Use base 0 to stay compatible with legacy platforms */
>> - ctrl->gc.base = 0;
>> + /* Dynamic allocation */
>> + ctrl->gc.base = -1;
>
>bgpip_init() will already have set gc.base to -1, so you can just drop
>the assignment.
>
>Best Regards,
>Jonas
>
Thanks, I've updated it in v2 patch:
https://lore.kernel.org/linux-gpio/TYCP286MB089598EA71E964BD8AB9EFD3BCD62@TYCP286MB0895.JPNP286.PROD.OUTLOOK.COM/
Regards,
Shiji Yang
prev parent reply other threads:[~2024-06-26 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 1:06 Shiji Yang
2024-06-25 14:16 ` Jonas Gorski
2024-06-26 0:42 ` Shiji Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCP286MB0895E5D272723AB55F9F4043BCD62@TYCP286MB0895.JPNP286.PROD.OUTLOOK.COM \
--to=yangshiji66@outlook.com \
--cc=albeu@free.fr \
--cc=brgl@bgdev.pl \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®