From: Dawei Li <set_pte_at@outlook.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Dawei Li <set_pte_at@outlook.com>
Subject: [PATCH] fs: remove obsolete comments on member ordering of random layout struct
Date: Tue, 7 Feb 2023 21:14:08 +0800 [thread overview]
Message-ID: <TYCP286MB2323C8F54CB121755B83F5D9CADB9@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM> (raw)
Structures marked with __randomize_layout are supposed to reorder layout
of members randomly. Although layout is not guranteed to be reordered
since dependency on hardening config, but let's not make assumption such
as "member foo is first".
Signed-off-by: Dawei Li <set_pte_at@outlook.com>
---
include/linux/fs.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index c1769a2c5d70..9114c4e44154 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -585,11 +585,6 @@ is_uncached_acl(struct posix_acl *acl)
struct fsnotify_mark_connector;
-/*
- * Keep mostly read-only and often accessed (especially for
- * the RCU path lookup and 'stat' data) fields at the beginning
- * of the 'struct inode'
- */
struct inode {
umode_t i_mode;
unsigned short i_opflags;
@@ -1471,7 +1466,7 @@ struct sb_writers {
};
struct super_block {
- struct list_head s_list; /* Keep this first */
+ struct list_head s_list;
dev_t s_dev; /* search index; _not_ kdev_t */
unsigned char s_blocksize_bits;
unsigned long s_blocksize;
--
2.25.1
next reply other threads:[~2023-02-07 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 13:14 Dawei Li [this message]
2023-02-07 18:04 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCP286MB2323C8F54CB121755B83F5D9CADB9@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM \
--to=set_pte_at@outlook.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®