From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "Michael Dege" <michael.dege@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Paul Barker" <paul@pbarker.dev>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael Dege" <michael.dege@renesas.com>,
"Nikita Yushchenko" <nikita.yoush@cogentembedded.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: RE: [PATCH v3 1/4] net: renesas: rswitch: rename rswitch.c to rswitch_main.c
Date: Mon, 14 Jul 2025 07:55:54 +0000 [thread overview]
Message-ID: <TYCPR01MB11040B37CC8F15CF82B75315FD854A@TYCPR01MB11040.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20250710-add_l2_switching-v3-1-c0a328327b43@renesas.com>
Hello Michael-san,
> From: Michael Dege, Sent: Thursday, July 10, 2025 9:31 PM
>
> Adding new functionality to the driver. Therefore splitting into multiple
> c files to keep them manageable. New functionality will be added to
> separate files.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
I think that these Reviewed-by: tags should be placed after your Signed-off-by
because you got these tags after you submitted.
> Signed-off-by: Michael Dege <michael.dege@renesas.com>
Anyway, this patch looks good to me.
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
> ---
> drivers/net/ethernet/renesas/Makefile | 1 +
> drivers/net/ethernet/renesas/{rswitch.c => rswitch_main.c} | 0
> 2 files changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
> index f65fc76f8b4df8dd9f24af836b6dc0772965366f..6222298bb5582b7091cf8de76acb83ac7dd39c11 100644
> --- a/drivers/net/ethernet/renesas/Makefile
> +++ b/drivers/net/ethernet/renesas/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_SH_ETH) += sh_eth.o
> ravb-objs := ravb_main.o ravb_ptp.o
> obj-$(CONFIG_RAVB) += ravb.o
>
> +rswitch-objs := rswitch_main.o
> obj-$(CONFIG_RENESAS_ETHER_SWITCH) += rswitch.o
>
> obj-$(CONFIG_RENESAS_GEN4_PTP) += rcar_gen4_ptp.o
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch_main.c
> similarity index 100%
> rename from drivers/net/ethernet/renesas/rswitch.c
> rename to drivers/net/ethernet/renesas/rswitch_main.c
>
> --
> 2.49.0
next prev parent reply other threads:[~2025-07-14 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 12:31 [PATCH v3 0/4] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching Michael Dege
2025-07-10 12:31 ` [PATCH v3 1/4] net: renesas: rswitch: rename rswitch.c to rswitch_main.c Michael Dege
2025-07-14 7:55 ` Yoshihiro Shimoda [this message]
2025-07-10 12:31 ` [PATCH v3 2/4] net: renesas: rswitch: configure default ageing time Michael Dege
2025-07-10 12:31 ` [PATCH v3 3/4] net: renesas: rswitch: add offloading for L2 switching Michael Dege
2025-07-15 11:00 ` Paolo Abeni
2025-07-15 11:10 ` Michael Dege
2025-08-11 10:46 ` Michael Dege
2025-07-10 12:31 ` [PATCH v3 4/4] net: renesas: rswitch: add modifiable ageing time Michael Dege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB11040B37CC8F15CF82B75315FD854A@TYCPR01MB11040.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=niklas.soderlund@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul@pbarker.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®