mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	biju.das.au <biju.das.au@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	magnus.damm <magnus.damm@gmail.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Conor Dooley <conor+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Thomas Gleixner <tglx@kernel.org>
Subject: RE: [PATCH 1/8] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/G3L SoC
Date: Wed, 4 Feb 2026 17:11:06 +0000	[thread overview]
Message-ID: <TYCPR01MB11332433AEC60539CE48CFDEE8698A@TYCPR01MB11332.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <177021852663.2044780.8530228995216202645.robh@kernel.org>

Hi Rob,

Thanks for the feedback.

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: 04 February 2026 15:22
> Subject: Re: [PATCH 1/8] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/G3L SoC
> 
> 
> On Wed, 04 Feb 2026 14:23:09 +0000, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Document RZ/G3L (R9A08G046) IRQC bindings. The IRQC block on RZ/G3L
> > SoC is almost identical to one found on the RZ/G3S SoC with the
> > difference like it support more External IRQs, GPT Error Interrupts
> > and also has additional registers for GPT/MTU IRQ selection, shared
> > IRQ selection between external IRQ and TINT. Hence new generic
> > compatible string "renesas,r9a08g046-irqc" is added for RZ/G3L SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> >  .../renesas,rzg2l-irqc.yaml                   | 66 +++++++++++++++++--
> >  1 file changed, 62 insertions(+), 4 deletions(-)
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-
> controller/renesas,rzg2l-irqc.example.dtb: interrupt-controller@110a0000 (renesas,r9a07g044-irqc):
> interrupt-names:9: 'irq8' was expected
> 	from schema $id: http://devicetree.org/schemas/interrupt-controller/renesas,rzg2l-irqc.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-
> controller/renesas,rzg2l-irqc.example.dtb: interrupt-controller@110a0000 (renesas,r9a07g044-irqc):
> interrupt-names:10: 'irq9' was expected

I will change it to pattern for fixing these errors

   interrupt-names:
     minItems: 45
+    maxItems: 61
+      oneOf:
+        - description: NMI interrupt
+          const: nmi
+        - description: External IRQ interrupt
+          pattern: '^irq([0-9]|1[0-5])$'
+        - description: GPIO interrupt
+          pattern: '^tint([0-9]|1[0-9]|2[0-9]|3[0-1])$'
+        - description: Bus error interrupt
+          const: bus-err
+        - description: ECCRAM0 or combined ECCRAM0/1 1bit error interrupt
+          const: ec7tie1-0
+        - description: ECCRAM0 or combined ECCRAM0/1 2bit error interrupt
+          const: ec7tie2-0
+        - description: ECCRAM0 or combined ECCRAM0/1 error overflow interrupt
+          const: ec7tiovf-0
+        - description: ECCRAM1 1bit error interrupt
+          const: ec7tie1-1
+        - description: ECCRAM1 2bit error interrupt
+          const: ec7tie2-1
+        - description: ECCRAM1 error overflow interrupt
+          const: ec7tiovf-1
+        - description: Integrated GPT Error interrupt
+          pattern: '^ovfunf[0-7]$'


Cheers,
Biju


  reply	other threads:[~2026-02-04 17:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 14:23 [PATCH 0/8] Add RZ/G3L IRQC support Biju
2026-02-04 14:23 ` [PATCH 1/8] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/G3L SoC Biju
2026-02-04 15:22   ` Rob Herring (Arm)
2026-02-04 17:11     ` Biju Das [this message]
2026-02-04 14:23 ` [PATCH 2/8] irqchip/renesas-rzg2l: Make fwspec variable as pointer in struct rzg2l_irqc_priv Biju
2026-02-04 14:23 ` [PATCH 3/8] irqchip/renesas-rzg2l: Drop IRQC_NUM_IRQ macro Biju
2026-02-04 14:23 ` [PATCH 4/8] irqchip/renesas-rzg2l: Drop IRQC_TINT_START macro Biju
2026-02-04 14:23 ` [PATCH 5/8] irqchip/renesas-rzg2l: Drop IRQC_IRQ_COUNT macro Biju
2026-02-04 14:23 ` [PATCH 6/8] irqchip/renesas-rzg2l: Add RZ/G3L support Biju
2026-02-04 14:23 ` [PATCH 7/8] irqchip/renesas-rzg2l: Add shared irq support Biju
2026-02-04 14:23 ` [PATCH 8/8] arm64: dts: renesas: r9a08g046: Add ICU node Biju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYCPR01MB11332433AEC60539CE48CFDEE8698A@TYCPR01MB11332.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=biju.das.au@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®