mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: geert <geert@linux-m68k.org>
Cc: Brian Masney <bmasney@redhat.com>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 11/13] clk: renesas: rzg2l-cpg: drop determine_rate op and use CLK_ROUNDING_FW_MANAGED flag
Date: Fri, 27 Feb 2026 16:04:54 +0000	[thread overview]
Message-ID: <TYCPR01MB113325811800F548C99EEE7C78673A@TYCPR01MB11332.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVfyfoETQ1dHPv7_N2Z-LJjw8DnE5T4YuOUNGpjqpsWZw@mail.gmail.com>

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 27 February 2026 16:01
> 
> Hi Biju,
> 
> On Fri, 27 Feb 2026 at 16:57, Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > From: Brian Masney <bmasney@redhat.com> On Fri, Feb 27, 2026 at
> > > 03:23:19PM +0000, Biju Das wrote:
> > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> On Fri, 27 Feb
> > > > > 2026 at 16:01, Brian Masney <bmasney@redhat.com> wrote:
> > > > > > On Fri, Feb 27, 2026 at 09:20:09AM +0100, Geert Uytterhoeven wrote:
> > > > > > > On Thu, 26 Feb 2026 at 19:18, Brian Masney <bmasney@redhat.com> wrote:
> > > > > > > > This clk driver has a noop determine_rate clk op. Drop
> > > > > > > > this empty function, and enable the CLK_ROUNDING_FW_MANAGED flag.
> > > > > > > >
> > > > > > > > Signed-off-by: Brian Masney <bmasney@redhat.com>
> > > > > > >
> > > > > > > Thanks for your patch!
> > > > > > >
> > > > > > > > --- a/drivers/clk/renesas/rzg2l-cpg.c
> > > > > > > > +++ b/drivers/clk/renesas/rzg2l-cpg.c
> > > > >
> > > > > > > > @@ -1041,7 +1034,7 @@ rzg2l_cpg_sipll5_register(const struct cpg_core_clk *core,
> > > > > > > >         init.name = core->name;
> > > > > > > >         parent_name = __clk_get_name(parent);
> > > > > > > >         init.ops = &rzg2l_cpg_sipll5_ops;
> > > > > > > > -       init.flags = 0;
> > > > > > > > +       init.flags = CLK_ROUNDING_FW_MANAGED;
> > > > > > >
> > > > > > > Iff this is the Right Thing To Do (TM), it needs a comment,
> > > > > > > as this clock is not managed by firmware.
> > > > > >
> > > > > > Before I start a larger discussion on patch 1 with more people
> > > > > > about a name for this flag, help me understand why this
> > > > > > provider has a noop determine rate. Is the hardware eventually
> > > > > > programmed with a rate that's close enough to what was passed
> > > > > > in? Or it doesn't really matter what the clock rate is, just
> > > > > > as long as it is running? Or should the determine_rate function be filled out in this
> particular case?
> > > > >
> > > > > I'd like to defer to Biju, who added the empty round^Wdetermine rate function.
> > > >
> > > > PLL is capable of generating any frequency. that is the reason.
> > > >
> > > > But we could, call rzg2l_cpg_get_foutpostdiv_rate() from
> > > > determine_rate() as modified rzg2l_cpg_get_foutpostdiv_rate()[1]
> > > > can return errors
> > > >
> > > > [1]
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.gi
> > > > t/tr
> > > > ee/drivers/clk/renesas/rzg2l-cpg.c?h=next-20260227#n590
> > >
> > > OK. So how do you all want to proceed here?
> > >
> > > Do you want to fill out the determine rate in this driver? If so, we
> > > can just drop this particular patch from this series.
> >
> > We plan to fill out the determine rate later, as it can return error.
> >
> > >
> > > Since the PLL is capable of any frequency, do you want to keep the empty determine rate
> functionality?
> > > If so, we could use a different name for this flag. Maybe CLK_ROUNDING_NOOP?
> >
> > I guess, maybe we could use CLK_ROUNDING_NOOP, till we have proper .determine_rate() for this
> driver???
> 
> Just keeping the empty function should work, too, right?

Yes, it will work.

Cheers,
Biju

  reply	other threads:[~2026-02-27 16:04 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 18:16 [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED Brian Masney
2026-02-26 18:16 ` [PATCH 01/13] " Brian Masney
2026-02-27  8:16   ` Geert Uytterhoeven
2026-02-27  8:57     ` Biju Das
2026-02-27 12:00   ` Biju Das
2026-02-27 14:44     ` Brian Masney
2026-02-27 16:38   ` Brian Masney
2026-03-02 11:27   ` Sudeep Holla
2026-02-26 18:16 ` [PATCH 02/13] clk: test: add test suite for CLK_ROUNDING_FW_MANAGED flag Brian Masney
2026-02-26 18:16 ` [PATCH 03/13] clk: rp1: drop determine_rate op and use " Brian Masney
2026-03-07  0:06   ` Andrea della Porta
2026-02-26 18:16 ` [PATCH 04/13] clk: scpi: " Brian Masney
2026-03-02 11:26   ` Sudeep Holla
2026-02-26 18:16 ` [PATCH 05/13] clk: hisilicon: hi3660-stub: " Brian Masney
2026-02-26 18:16 ` [PATCH 06/13] clk: imx: scu: drop redundant init.ops variable assignment Brian Masney
2026-02-27  2:02   ` Peng Fan
2026-02-26 18:16 ` [PATCH 07/13] clk: imx: scu: drop determine_rate op and use CLK_ROUNDING_FW_MANAGED flag Brian Masney
2026-02-27  2:04   ` Peng Fan
2026-02-26 18:16 ` [PATCH 08/13] clk: qcom: rpm: " Brian Masney
2026-02-27  0:07   ` Dmitry Baryshkov
2026-02-26 18:16 ` [PATCH 09/13] clk: qcom: rpmh: " Brian Masney
2026-02-27  0:12   ` Dmitry Baryshkov
2026-02-26 18:16 ` [PATCH 10/13] clk: qcom: smd-rpm: " Brian Masney
2026-02-27  0:13   ` Dmitry Baryshkov
2026-02-26 18:16 ` [PATCH 11/13] clk: renesas: rzg2l-cpg: " Brian Masney
2026-02-27  8:20   ` Geert Uytterhoeven
2026-02-27 14:46     ` Brian Masney
2026-02-27 15:01     ` Brian Masney
2026-02-27 15:09       ` Geert Uytterhoeven
2026-02-27 15:23         ` Biju Das
2026-02-27 15:48           ` Brian Masney
2026-02-27 15:57             ` Biju Das
2026-02-27 16:01               ` Brian Masney
2026-02-27 16:01               ` Geert Uytterhoeven
2026-02-27 16:04                 ` Biju Das [this message]
2026-02-26 18:16 ` [PATCH 12/13] clk: samsung: acpm: " Brian Masney
2026-02-28 13:31   ` Krzysztof Kozlowski
2026-02-26 18:16 ` [PATCH 13/13] clk: sprd: " Brian Masney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYCPR01MB113325811800F548C99EEE7C78673A@TYCPR01MB11332.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Brandt@renesas.com \
    --cc=bmasney@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®