From: Biju Das <biju.das.jz@bp.renesas.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: biju.das.au <biju.das.au@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Thierry Bultel <thierry.bultel.yh@bp.renesas.com>,
wsa+renesas <wsa+renesas@sang-engineering.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] serial: sh-sci: Avoid divide-by-zero fault
Date: Wed, 8 Apr 2026 19:02:13 +0000 [thread overview]
Message-ID: <TYCPR01MB113326DDA1FC854689CE34A6C865B2@TYCPR01MB11332.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20260408141515.fc210b4b3c86f7a61f680dd1@hugovil.com>
Hi Hugo,
> -----Original Message-----
> From: Hugo Villeneuve <hugo@hugovil.com>
> Sent: 08 April 2026 19:15
> Subject: Re: [PATCH v2 1/2] serial: sh-sci: Avoid divide-by-zero fault
>
> Hi Biju,
>
> On Wed, 8 Apr 2026 17:25:19 +0000
> Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> > Hi Hugo,
> >
> > > -----Original Message-----
> > > From: Hugo Villeneuve <hugo@hugovil.com>
> > > Sent: 08 April 2026 17:52
> > > Subject: Re: [PATCH v2 1/2] serial: sh-sci: Avoid divide-by-zero
> > > fault
> > >
> > > Hi Biju,
> > >
> > > On Wed, 8 Apr 2026 16:35:44 +0000
> > > Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > >
> > > > Hi Hugo,
> > > >
> > > > Thanks for the feedback.
> > > >
> > > > > -----Original Message-----
> > > > > From: Hugo Villeneuve <hugo@hugovil.com>
> > > > > Sent: 08 April 2026 17:31
> > > > > Subject: Re: [PATCH v2 1/2] serial: sh-sci: Avoid divide-by-zero
> > > > > fault
> > > > >
> > > > > Hi Biju,
> > > > >
> > > > > On Wed, 8 Apr 2026 15:20:58 +0100 Biju <biju.das.au@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > > > >
> > > > > > uart_update_timeout() computes a timeout value by dividing by
> > > > > > the baud rate. If baud is zero — which can occur when the
> > > > > > hardware returns an unsupported or invalid rate — this results in a divide-by-zero fault.
> > > > >
> > > > > baud is returned by uart_get_baud_rate(), so this is not returned by the hardware?
> > > >
> > > > You are tight, Will update commit description.
> > >
> > > How can uart_get_baud_rate() return a zero value? If I am not
> > > mistaken even for the B0 case, it will return 9600?
> >
> > As per the comment and code, this API can return 0.
> >
> > * If the new baud rate is invalid, try the @old termios setting. If
> > it's still
> > * invalid, we try 9600 baud. If that is also invalid 0 is returned.
> >
> > In drives/tty currently only 1 driver is checking the return value and
> > it calls panic
> >
> > https://elixir.bootlin.com/linux/v7.0-rc7/source/drivers/tty/serial/ap
> > buart.c#L214
>
> Hmmm, more than 1:
>
> icom.c:
> if (!baud)
> baud = 9600; /* B0 transition handled in rs_set_termios */
A zero return from uart_get_baud_rate() is a normal, recoverable condition
(unsupported rate requested by userspace) and must not crash the kernel.
Or drop the check like other tty drivers, as SCIF/RSCI IP support 9600 baud rate.
Cheers,
Biju
next prev parent reply other threads:[~2026-04-08 19:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 14:20 [PATCH v2 0/2] serial: sh-sci/rsci: Fix divide by zero and clean up baud rate logic Biju
2026-04-08 14:20 ` [PATCH v2 1/2] serial: sh-sci: Avoid divide-by-zero fault Biju
2026-04-08 15:39 ` Geert Uytterhoeven
2026-04-08 16:05 ` Biju Das
2026-04-08 16:30 ` Hugo Villeneuve
2026-04-08 16:35 ` Biju Das
2026-04-08 16:51 ` Hugo Villeneuve
2026-04-08 17:25 ` Biju Das
2026-04-08 18:15 ` Hugo Villeneuve
2026-04-08 19:02 ` Biju Das [this message]
2026-04-09 7:40 ` Biju Das
2026-04-09 14:16 ` Hugo Villeneuve
2026-04-13 10:24 ` Geert Uytterhoeven
2026-04-16 16:31 ` Biju Das
2026-04-08 14:20 ` [PATCH v2 2/2] serial: rsci: Remove goto and refactor baud rate clock selection Biju
2026-04-08 15:45 ` Geert Uytterhoeven
2026-04-08 15:53 ` Geert Uytterhoeven
2026-04-08 16:01 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB113326DDA1FC854689CE34A6C865B2@TYCPR01MB11332.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=biju.das.au@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®