From: "NOMURA JUNICHI(野村 淳一)" <junichi.nomura@nec.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"ardb@kernel.org" <ardb@kernel.org>,
"david@redhat.com" <david@redhat.com>,
"nikunj@amd.com" <nikunj@amd.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"debarbos@redhat.com" <debarbos@redhat.com>,
"jlelli@redhat.com" <jlelli@redhat.com>,
"lgoncalv@redhat.com" <lgoncalv@redhat.com>,
"dzickus@redhat.com" <dzickus@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] x86/boot: Add a message about ignored early NMIs
Date: Wed, 24 Jan 2024 11:44:28 +0000 [thread overview]
Message-ID: <TYCPR01MB8389C46BF755C31EACE8DB37837B2@TYCPR01MB8389.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20240123112624.GBZa-iYP1l9SSYtr-V@fat_crate.local>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
> From: Borislav Petkov <bp@alien8.de>
> On Mon, Jan 15, 2024 at 08:57:45AM +0000, NOMURA JUNICHI(野村 淳一) wrote:
> > + if (spurious_nmi_count) {
> > + error_putstr("Spurious early NMI ignored. Number of NMIs: 0x");
> > + error_puthex(spurious_nmi_count);
> > + error_putstr("\n");
>
> Uff, that's just silly:
>
> Spurious early NMIs ignored: 0x0000000000000017
>
> Would you like to add a error_putnum() or so in a prepatch which would
> make this output
>
> Spurious early NMIs ignored: 23.
>
> ?
>
> So that it is human readable and doesn't make me wonder what that hex
> value is supposed to mean?
Yes, it would be nicer to print that way. I used the existing error_puthex() just
to keep the patch minimal. I will try to add error_putnum().
> Btw, please use this version when sending next time:
Thank you.
--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5779 bytes --]
next prev parent reply other threads:[~2024-01-24 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 11:13 [PATCH repost] " NOMURA JUNICHI(野村 淳一)
2024-01-12 12:06 ` kirill.shutemov
2024-01-15 8:57 ` [PATCH v2] " NOMURA JUNICHI(野村 淳一)
2024-01-15 10:14 ` kirill.shutemov
2024-01-23 11:26 ` Borislav Petkov
2024-01-24 11:44 ` NOMURA JUNICHI(野村 淳一) [this message]
2024-01-25 2:00 ` H. Peter Anvin
2024-01-26 2:15 ` NOMURA JUNICHI(野村 淳一)
2024-02-01 17:22 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB8389C46BF755C31EACE8DB37837B2@TYCPR01MB8389.jpnprd01.prod.outlook.com \
--to=junichi.nomura@nec.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=debarbos@redhat.com \
--cc=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=jlelli@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®