RE: [PATCH v6 2/6] dt-bindings: dma: rz-dmac: Document RZ/V2H(P) family of SoCs

[Fabrizio Castro <fabrizio.castro.jz@renesas.com>]

Hi Geert,

> From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Sent: 23 April 2025 14:27
> Subject: RE: [PATCH v6 2/6] dt-bindings: dma: rz-dmac: Document RZ/V2H(P) family of SoCs
> 
> Hi Geert,
> 
> Thanks for your feedback!
> 
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > Sent: 23 April 2025 12:37
> > Subject: Re: [PATCH v6 2/6] dt-bindings: dma: rz-dmac: Document RZ/V2H(P) family of SoCs
> >
> > Hi Fabrizio,
> >
> > On Tue, 22 Apr 2025 at 19:40, Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com> wrote:
> > > Document the Renesas RZ/V2H(P) family of SoCs DMAC block.
> > > The Renesas RZ/V2H(P) DMAC is very similar to the one found on the
> > > Renesas RZ/G2L family of SoCs, but there are some differences:
> > > * It only uses one register area
> > > * It only uses one clock
> > > * It only uses one reset
> > > * Instead of using MID/IRD it uses REQ No
> > > * It is connected to the Interrupt Control Unit (ICU)
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > > v5->v6:
> > > * Reworked the description of `#dma-cells`.
> > > * Reworked `renesas,icu` related descriptions.
> > > * Added `reg:`->`minItems: 2` for `renesas,r7s72100-dmac`.
> > > * Since the structure of the document remains the same, I have kept
> > >   the tags I have received. Please let me know if that's not okay.
> >
> > Thanks for the update!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> > > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> > > @@ -80,12 +85,26 @@ properties:
> > >      items:
> > >        - description: Reset for DMA ARESETN reset terminal
> > >        - description: Reset for DMA RST_ASYNC reset terminal
> > > +    minItems: 1
> > >
> > >    reset-names:
> > >      items:
> > >        - const: arst
> > >        - const: rst_async
> > >
> > > +  renesas,icu:
> > > +    description:
> > > +      It must contain the phandle to the ICU, and the index of the DMAC as seen
> > > +      from the ICU (e.g. parameter k from register ICU_DMkSELy).
> >
> > Doesn't really hurt, but this description is identical to the formal
> > description of the items below.
> 
> Okay, I'll drop this description, and I'll keep the description for the item below.

Actually, I cannot take this out:

	'description' is a dependency of '$ref'
	'/schemas/types.yaml#/definitions/phandle-array' does not match '^#/(definitions|\\$defs)/'
		hint: A vendor property can have a $ref to a a $defs schema
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.

I'll rephrase the description to:
It must contain the phandle to the ICU and the DMAC index as seen from the ICU.

Thanks!

Cheers,
Fab

> 
> >
> > > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > +    items:
> > > +      - items:
> > > +          - description: phandle to the ICU node.
> >
> > Phandle
> 
> And I'll amend accordingly.
> 
> I'll send a new version shortly.
> 
> Thanks!
> 
> Cheers,
> Fab
> 
> >
> > > +          - description:
> > > +              The number of the DMAC as seen from the ICU, i.e. parameter k from
> > > +              register ICU_DMkSELy. This may differ from the actual DMAC instance
> > > +              number.
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> >
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds