From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lee Jones <lee@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: RE: [PATCH v2 2/4] mfd: Add RZ/V2M PWC core driver
Date: Tue, 3 Jan 2023 12:05:06 +0000 [thread overview]
Message-ID: <TYWPR01MB87758FB15ED12D396AE738DDC2F49@TYWPR01MB8775.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXDwEUzBpG+w_G6=CzKo=n92cdVw6v8JwOwf9o86HnOZQ@mail.gmail.com>
Hi Geert,
Thanks for your feedback!
> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 03 January 2023 08:37
> To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski
> <brgl@bgdev.pl>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Sebastian Reichel <sre@kernel.org>;
> Geert Uytterhoeven <geert+renesas@glider.be>; Lee Jones <lee@kernel.org>;
> linux-gpio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-pm@vger.kernel.org; Chris Paterson
> <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>; linux-
> renesas-soc@vger.kernel.org; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>; Jacopo Mondi <jacopo@jmondi.org>
> Subject: Re: [PATCH v2 2/4] mfd: Add RZ/V2M PWC core driver
>
> Hi Fabrizio,
>
> On Wed, Dec 21, 2022 at 10:09 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > The External Power Sequence Controller (PWC) IP (found in the
> > RZ/V2M SoC) is a controller for external power supplies (regulators
> > and power switches), and it supports the following features: it
> > generates a power on/off sequence for external power supplies,
> > it generates an on/off sequence for the LPDDR4 core power supply
> > (LPVDD), it comes with General-Purpose Outputs, and it processes
> > key input signals.
>
> Thanks for your patch!
>
> > The PWC is basically a Multi-Function Device (MFD), its software
> > support comes with a core driver, and specialized drivers for
> > its specific features.
>
> I have to admit I'm not such a big fan of MFD. In this driver,
> you are not even sharing resources in the MFD cells, just the mapped
> register base. So I think you can easily save +100 LoC and reduce
> maintenance synchronization overhead across subsystems by just having
> a single non-MFD driver instead.
>
> Did you pick MFD because the PWC poweroff feature depends on board
> wiring, and thus is optional?
I am not a big fan of MFD, either.
I picked MFD because we were not 100% sure of what the IP could do
when we started working on it.
I have received more information regarding the IP now (which I don't
have the liberty to discuss), I am still not 100% sure that's all
of it, but basically its support may require expansion later on.
I liked the solution based on syscon and simple-mfd for several reasons,
but having dropped syscon and simple-mfd due to issues with the dt-bindings
I have moved on with a core driver to instantiate the required SW support.
We could of course move to a unified driver if that makes more sense?
If we were to move to unified driver, under which directory would you
suggest we put it?
>
> Are there any other MFD cells planned (e.g. regulators) to be added
> later? The public datasheet does not list the actual registers of the
> block, only a high-level overview with (rather detailed) behavioral
> information.
No MFD cells are planned for now, but I can't exclude we won't
have any in the future.
Thanks,
Fab
>
> Thanks!
>
> > --- /dev/null
> > +++ b/drivers/mfd/rzv2m-pwc.h
>
> > +struct rzv2m_pwc_priv {
> > + void __iomem *base;
> > +};
> > +
> > +#endif /* __LINUX_RZV2M_PWC_H__ */
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
next prev parent reply other threads:[~2023-01-03 12:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 21:09 [PATCH v2 0/4] Driver support for RZ/V2M PWC Fabrizio Castro
2022-12-21 21:09 ` [PATCH v2 1/4] dt-bindings: mfd: Add " Fabrizio Castro
2022-12-22 18:09 ` Rob Herring
2023-01-03 8:29 ` Geert Uytterhoeven
2023-01-03 16:29 ` Fabrizio Castro
2022-12-21 21:09 ` [PATCH v2 2/4] mfd: Add RZ/V2M PWC core driver Fabrizio Castro
2023-01-03 8:36 ` Geert Uytterhoeven
2023-01-03 12:05 ` Fabrizio Castro [this message]
2023-01-03 12:10 ` Geert Uytterhoeven
2023-01-03 15:00 ` Fabrizio Castro
2023-01-03 12:52 ` Lee Jones
2023-01-03 15:46 ` Fabrizio Castro
2023-01-04 14:34 ` Lee Jones
2023-01-04 15:46 ` Fabrizio Castro
2023-01-04 16:05 ` Lee Jones
2022-12-21 21:09 ` [PATCH v2 3/4] gpio: Add support for the Renesas RZ/V2M PWC GPIOs Fabrizio Castro
2022-12-29 0:40 ` Linus Walleij
2022-12-21 21:09 ` [PATCH v2 4/4] power: reset: Add new driver for RZ/V2M PWC poweroff Fabrizio Castro
2023-01-02 19:22 ` Sebastian Reichel
2023-01-03 8:26 ` Geert Uytterhoeven
2023-01-05 17:33 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYWPR01MB87758FB15ED12D396AE738DDC2F49@TYWPR01MB8775.jpnprd01.prod.outlook.com \
--to=fabrizio.castro.jz@renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®