mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: geert <geert@linux-m68k.org>, "biju.das.au" <biju.das.au@gmail.com>
Cc: "magnus.damm" <magnus.damm@gmail.com>,
	wsa+renesas <wsa+renesas@sang-engineering.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add SDHI nodes for RZ/G3L SoC and SDHI1 pincontrol on SMARC EVK
Date: Fri, 20 Nov 2026 13:14:37 +0000	[thread overview]
Message-ID: <TYYPR01MB6603B59F47E78CC7DDBF50B986782@TYYPR01MB6603.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWk_0VT_UgaYoCW8c9zac2g88bL6niZF6aDu+UbWroFjw@mail.gmail.com>

Hi Geert,

Thanks for the feedback

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 20 November 2026 12:52
> Subject: Re: [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add SDHI nodes for RZ/G3L SoC and SDHI1
> pincontrol on SMARC EVK
> 
> Hi Biju,
> 
> On Thu, 12 Nov 2026 at 19:48, Biju Das <biju.das.au@gmail.com> wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Add device tree nodes for the three SDHI controllers (SDHI{0,1,2}) on
> > the RZ/G3L SoC (r9a08g046) and enable SDHI1 on the RZ/G3L SMARC EVK
> > platform with pincontrol and GPIO-based voltage switching regulator
> > support.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> > @@ -1062,9 +1062,80 @@ dmac: dma-controller@11820000 {
> >                         dma-channels = <16>;
> >                 };
> >
> > +               sdhi0: mmc@11c00000 {
> > +                       compatible = "renesas,sdhi-r9a08g046";
> > +                       reg = <0x0 0x11c00000 0 0x10000>;
> > +                       interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD R9A08G046_SDHI0_IMCLK>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI0_CLK_HS>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI0_IMCLK2>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI0_IACLKM>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI0_IACLKS>;
> > +                       clock-names = "core", "clkh", "cd", "aclkm", "aclks";
> > +                       max-frequency = <150000000>;
> 
> Given the bus clock can only run at 200, 100, 50, or 6.25 MHz,
> 150 Mhz looks strange to me.

Ref: RZG3L_clock_list_r1.10_ad.xlsx 
400 MHz IMCL{K,K2} clock is prohibited for this SoC.
800 MHz HS clock is prohibited for this SoC.

IMCLK = SD / 2
HS = SD

IMCLK clock sources 
400 MHz:- Prohibited
300.000 
250.000
133.333


The next available max frequency = 300 / 2 = 150 MHz that goes to
SD interface.

> 
> > +                       resets = <&cpg R9A08G046_SDHI0_IXRST>,
> > +                                <&cpg R9A08G046_SDHI0_IXRSTAXIM>,
> > +                                <&cpg R9A08G046_SDHI0_IXRSTAXIS>;
> > +                       reset-names = "rst", "axim", "axis";
> > +                       power-domains = <&cpg>;
> > +                       status = "disabled";
> > +               };
> > +
> >                 sdhi1: mmc@11c10000 {
> > +                       compatible = "renesas,sdhi-r9a08g046";
> >                         reg = <0x0 0x11c10000 0 0x10000>;
> > -                       /* placeholder */
> > +                       interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD R9A08G046_SDHI1_IMCLK>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI1_CLK_HS>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI1_IMCLK2>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI1_IACLKM>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI1_IACLKS>;
> > +                       clock-names = "core", "clkh", "cd", "aclkm", "aclks";
> > +                       max-frequency = <150000000>;
> 
> Likewise. This instance does not support HS400, but HS200 and HS400 use the same bus clock speed,
> right?

Yes that is correct, HS200 and HS400 use the same bus clock speed

for HS200 it is 1:1 option, so 300MHz and with internal divider(2) = 150 MHz

For HS400, Divider from SDctrl register=0, so 300MHz with SD_CTRL divider 2 =150 MHz.

> 
> > +                       resets = <&cpg R9A08G046_SDHI1_IXRST>,
> > +                                <&cpg R9A08G046_SDHI1_IXRSTAXIM>,
> > +                                <&cpg R9A08G046_SDHI1_IXRSTAXIS>;
> > +                       reset-names = "rst", "axim", "axis";
> > +                       power-domains = <&cpg>;
> > +                       status = "disabled";
> > +
> > +                       sdhi1_vqmmc: vqmmc-regulator {
> > +                               regulator-name = "SDHI1-VQMMC";
> > +                               regulator-min-microvolt = <1800000>;
> > +                               regulator-max-microvolt = <3300000>;
> > +                               regulator-ramp-delay = <1200>;
> > +                               status = "disabled";
> > +                       };
> > +               };
> > +
> > +               sdhi2: mmc@11c20000 {
> > +                       compatible = "renesas,sdhi-r9a08g046";
> > +                       reg = <0x0 0x11c20000 0 0x10000>;
> > +                       interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD R9A08G046_SDHI2_IMCLK>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI2_CLK_HS>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI2_IMCLK2>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI2_IACLKM>,
> > +                                <&cpg CPG_MOD R9A08G046_SDHI2_IACLKS>;
> > +                       clock-names = "core", "clkh", "cd", "aclkm", "aclks";
> > +                       max-frequency = <150000000>;
> 
> This instance maxes out at SDR104, so max-frequency should be lower?

SDR104 max frequency theoretical 208MHz.

In our SoC, 200 MHz is prohibited, so the next maximum available is 150MHz.

Cheers,
Biju

  reply	other threads:[~2026-11-20 13:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:48 [PATCH 0/3] Enable RZ/G3L SDHI Biju Das
2026-11-12 18:48 ` [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add SDHI nodes for RZ/G3L SoC and SDHI1 pincontrol on SMARC EVK Biju Das
2026-11-20 12:52   ` Geert Uytterhoeven
2026-11-20 13:14     ` Biju Das [this message]
2026-11-20 13:22       ` Geert Uytterhoeven
2026-11-12 18:48 ` [PATCH 2/3] arm64: dts: renesas: rzg3l-smarc-som: Enable SD/eMMC on SDHI0 Biju Das
2026-11-20 13:04   ` Geert Uytterhoeven
2026-11-12 18:48 ` [PATCH 3/3] arm64: dts: renesas: rzg3l-smarc-som: Enable SDHI2 Biju Das
2026-11-20 13:17   ` Geert Uytterhoeven
2026-11-20 13:22     ` Biju Das
2026-11-20 13:23       ` Geert Uytterhoeven
2026-11-20 15:32         ` Biju Das
2026-11-16 10:05 ` [PATCH 0/3] Enable RZ/G3L SDHI Wolfram Sang
2026-11-16 10:09   ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYYPR01MB6603B59F47E78CC7DDBF50B986782@TYYPR01MB6603.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=biju.das.au@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®