From: Akisaira <akisaira@outlook.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: don't reset userspace_init_fs when PID 1 stops sharing it
Date: Sun, 22 Nov 2026 05:09:47 +1100 [thread overview]
Message-ID: <TYYPR01MB8167C4C0641826B070DB684FA6472@TYYPR01MB8167.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20261119-work-fs-pid1_unshare-v1-2-b6a7e468bd68@kernel.org>
On Thu, Nov 19, 2026 at 02:25:02PM +0100, Christian Brauner wrote:
> There are a couple of fixes to not leave stale state behind but it seems
> that there is legitimate userspace out there that does need this. So
> stop resetting userspace_init_fs for now. I can probably rework this to
> something sane but I'm not sure it's worth it. Kthreads and
> usermodehelpers keep using what PID 1 left behind, just like they kept
> using init_fs before PID 1 got its own fs_struct. Keep the notice
> though but downgrade it to pr_info().
Thanks for the quick fix. I applied both patches on top of v7.4-rc3
instead of my local workaround and booted Android 17 on arm64
(Qualcomm SC8280XP).
Android boots cleanly with no init property denials, "VFS: Pid 1 stopped
sharing filesystem state" appears once at info level, and post-unshare
direct firmware loads from /vendor/firmware (ath11k, Adreno SQE/GMU, QCA
Bluetooth) continue to work. I didn't exercise the pivot_root() path in
1/2 since Android doesn't use pivot_root(), so tagging 2/2 only.
Tested-by: Akisaira <akisaira@outlook.com>
prev parent reply other threads:[~2026-11-21 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 13:25 [PATCH 0/2] " Christian Brauner
2026-11-19 13:25 ` [PATCH 1/2] fs: let pivot_root() move userspace_init_fs when nobody shares it Christian Brauner
2026-11-19 13:25 ` [PATCH 2/2] fs: don't reset userspace_init_fs when PID 1 stops sharing it Christian Brauner
2026-11-21 18:09 ` Akisaira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYYPR01MB8167C4C0641826B070DB684FA6472@TYYPR01MB8167.jpnprd01.prod.outlook.com \
--to=akisaira@outlook.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®