mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shawn.shao <shawn.shao@jaguarmicro.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] lib: Export the parsing functions and related data structures of the PLDM library
Date: Wed, 11 Sep 2024 01:32:55 +0000	[thread overview]
Message-ID: <TYZPR06MB393378C4807373C77856F3FE9D9B2@TYZPR06MB3933.apcprd06.prod.outlook.com> (raw)

> >On 9/9/2024 7:47 PM, Shawn.Shao wrote:
> > From: Shawn Shao <shawn.shao@jaguarmicro.com>
> >
> > v1 -> v2: Updated the commit message, added a description
> >       of the changes related to `DeviceUpdateOptionFlags`, etc.
> > v2 -> v3: separate the device_update_flags into another patch
> >
> 
> Minor nit, not worth a re-roll on its own, but the new title does not
> mention pldmfw.

Due to the use of a line break in the email subject, the title was truncated. 
This was my oversight, and I have now corrected it. Thank you!
Please find the corrected patch at the following link:
https://lore.kernel.org/all/20240911012444.1979-1-shawn.shao@jaguarmicro.com/

> > The PLDM library is used to implement firmware upgrades,
> > but the current library functions only support the
> > `pldmfw_flash_image` function to complete a fixed
> > process of parsing, sending data to the backend,
> > and flashing (allowing users to implement custom
> > logic using `pldmfw_ops`). However, this poses
> > significant challenges for device vendors using
> > PLDM for firmware upgrades.
> > The following scenarios are not supported:
> > 1. Only using the PLDM parsing functions, as the
> >    current library does not support this operation.
> > 2. The firmware upgrade process differs from this
> >    fixed flow (the firmware upgrade process may
> >    vary across different vendors).
> >       |-> pldmfw_flash_image
> >               |-> pldm_parse_image
> >                       |-> pldm_parse_header
> >                       |-> pldm_parse_records
> >                       |-> pldm_parse_components
> >                       -> pldm_verify_header_crc
> >               |-> pldm_find_matching_record (xxx_match_record)
> >               |-> pldm_send_package_data (xxx_send_package_data)
> >               |-> pldm_send_component_tables
> (xxx_send_package_data)
> >               |-> pldm_flash_components (xxx_flash_component)
> >               |-> pldm_finalize_update (xxx_finalize_update)
> >
> > Signed-off-by: Shawn Shao <shawn.shao@jaguarmicro.com>
> > ---
> 
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>


Thanks!

             reply	other threads:[~2024-09-11  1:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  1:32 shawn.shao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-09-11  1:24 Shawn.Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYZPR06MB393378C4807373C77856F3FE9D9B2@TYZPR06MB3933.apcprd06.prod.outlook.com \
    --to=shawn.shao@jaguarmicro.com \
    --cc=jacob.e.keller@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®