From: Jammy Huang <jammy_huang@aspeedtech.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>
Subject: RE: [PATCH v6 2/2] mailbox: aspeed: add mailbox driver for AST27XX series SoC
Date: Fri, 25 Jul 2025 10:24:57 +0000 [thread overview]
Message-ID: <TYZPR06MB656867AD5FF1FCA04E770BBCF159A@TYZPR06MB6568.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CABb+yY1kyZdMqcMRUEdqCYByQE=DurfnejtvuQsMf9wfLiij2g@mail.gmail.com>
> On Tue, Jul 1, 2025 at 8:19 PM Jammy Huang
> <jammy_huang@aspeedtech.com> wrote:
>
> .....
> > + /* Read the message data */
> > + for (data_reg = mb->rx_regs + IPCR_DATA +
> mb->msg_size * n,
> > + word_data = chan->con_priv,
> > + num_words = (mb->msg_size / sizeof(u32));
> > + num_words;
> > + num_words--, data_reg += sizeof(u32),
> word_data++)
> > + *word_data = readl(data_reg);
> > +
> Please clean this for loop.
OK, will be updated in later patch.
Thanks for help.
>
> Thanks
> -Jassi
Regards.
prev parent reply other threads:[~2025-07-25 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 1:19 [PATCH v6 0/2] ASPEED: Add mailbox driver for AST2700 series Jammy Huang
2025-07-02 1:19 ` [PATCH v6 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC Jammy Huang
2025-07-04 0:11 ` Andrew Jeffery
2025-07-02 1:19 ` [PATCH v6 2/2] mailbox: aspeed: add mailbox driver for AST27XX " Jammy Huang
2025-07-04 1:24 ` Andrew Jeffery
2025-07-20 19:51 ` Jassi Brar
2025-07-25 10:24 ` Jammy Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYZPR06MB656867AD5FF1FCA04E770BBCF159A@TYZPR06MB6568.apcprd06.prod.outlook.com \
--to=jammy_huang@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®