mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neal Liu <neal_liu@aspeedtech.com>
To: Corentin Labbe <clabbe@baylibre.com>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"john.allen@amd.com" <john.allen@amd.com>,
	"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: Move akcipher_request_cast helper to crypto header
Date: Mon, 2 Oct 2023 03:21:56 +0000	[thread overview]
Message-ID: <TYZPR06MB6770E43899C7AB66FF55FAC280C5A@TYZPR06MB6770.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20231001201357.2052949-1-clabbe@baylibre.com>

> -----Original Message-----
> From: Corentin Labbe <clabbe@baylibre.com>
> Sent: Monday, October 2, 2023 4:14 AM
> To: andrew@aj.id.au; davem@davemloft.net; herbert@gondor.apana.org.au;
> joel@jms.id.au; john.allen@amd.com; Neal Liu <neal_liu@aspeedtech.com>;
> thomas.lendacky@amd.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Corentin Labbe
> <clabbe@baylibre.com>
> Subject: [PATCH] crypto: Move akcipher_request_cast helper to crypto header
> 
> There is already 2 driver implementing their own akcipher_request_cast.
> In the future there will be also rockchip and allwinner driver that will need
> this.
> This is sufficient to move it in crypto headers.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>
Thanks.

> ---
>  drivers/crypto/aspeed/aspeed-acry.c | 6 ------
> drivers/crypto/ccp/ccp-crypto-rsa.c | 6 ------
>  include/crypto/akcipher.h           | 7 +++++++
>  3 files changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/crypto/aspeed/aspeed-acry.c
> b/drivers/crypto/aspeed/aspeed-acry.c
> index 247c568aa8df..ecb6e984367b 100644
> --- a/drivers/crypto/aspeed/aspeed-acry.c
> +++ b/drivers/crypto/aspeed/aspeed-acry.c
> @@ -137,12 +137,6 @@ enum aspeed_rsa_key_mode {
>  	ASPEED_RSA_DATA_MODE,
>  };
> 
> -static inline struct akcipher_request *
> -	akcipher_request_cast(struct crypto_async_request *req)
> -{
> -	return container_of(req, struct akcipher_request, base);
> -}
> -
>  static int aspeed_acry_do_fallback(struct akcipher_request *req)  {
>  	struct crypto_akcipher *cipher = crypto_akcipher_reqtfm(req); diff --git
> a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
> index a14f85512cf4..32c9f524f3d5 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -19,12 +19,6 @@
> 
>  #include "ccp-crypto.h"
> 
> -static inline struct akcipher_request *akcipher_request_cast(
> -	struct crypto_async_request *req)
> -{
> -	return container_of(req, struct akcipher_request, base);
> -}
> -
>  static inline int ccp_copy_and_save_keypart(u8 **kpbuf, unsigned int *kplen,
>  					    const u8 *buf, size_t sz)
>  {
> diff --git a/include/crypto/akcipher.h b/include/crypto/akcipher.h index
> 670508f1dca1..4b6e610db18d 100644
> --- a/include/crypto/akcipher.h
> +++ b/include/crypto/akcipher.h
> @@ -498,4 +498,11 @@ static inline int crypto_akcipher_set_priv_key(struct
> crypto_akcipher *tfm,
> 
>  	return alg->set_priv_key(tfm, key, keylen);  }
> +
> +static inline struct akcipher_request *
> +	akcipher_request_cast(struct crypto_async_request *req) {
> +	return container_of(req, struct akcipher_request, base); }
> +
>  #endif
> --
> 2.41.0


  reply	other threads:[~2023-10-02  3:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 20:13 Corentin Labbe
2023-10-02  3:21 ` Neal Liu [this message]
2023-10-02 13:25 ` Tom Lendacky
2023-10-05  4:09 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYZPR06MB6770E43899C7AB66FF55FAC280C5A@TYZPR06MB6770.apcprd06.prod.outlook.com \
    --to=neal_liu@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=joel@jms.id.au \
    --cc=john.allen@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®