mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cunyuan Liu <cunyuan.liu@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"simona@ffwll.ch" <simona@ffwll.ch>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"marex@nabladev.com" <marex@nabladev.com>,
	"dev@kael-k.io" <dev@kael-k.io>,
	"prabhakar.mahadev-lad.rj@bp.renesas.com"
	<prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"andre.przywara@arm.com" <andre.przywara@arm.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: [PATCH 2/3] dt-bindings: display: arm,komeda: add Arm China Linlon D6 compatible
Date: Thu, 12 Mar 2026 08:15:54 +0000	[thread overview]
Message-ID: <TYZPR06MB7334C88FD32F5428E4F9D263F844A@TYZPR06MB7334.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <de86f0ca-8d63-48c3-a1ae-3c1a801bef5f@kernel.org>


> On 11/03/2026 06:55, Cunyuan Liu wrote:
> > Add the Arm China Linlon D6 display controller compatible string.
> >
> > Linlon D6 is register-compatible with Mali-D71, so describe it as a
> > vendor-specific compatible with a fallback to "arm,mali-d71".
> >
> > Signed-off-by: Cunyuan Liu <cunyuan.liu@cixtech.com>
> > ---
> >  Documentation/devicetree/bindings/display/arm,komeda.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml
> > b/Documentation/devicetree/bindings/display/arm,komeda.yaml
> > index 3ad3eef89ca8..56fb4103b0dd 100644
> > --- a/Documentation/devicetree/bindings/display/arm,komeda.yaml
> > +++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml
> > @@ -21,6 +21,9 @@ properties:
> >        - items:
> >            - const: arm,mali-d32
> >            - const: arm,mali-d71
> > +      - items:
> > +          - const: armchina,linlon-d6
> 
> So that's enum in previous d32 entry.

Hi Krzysztof,

Thanks for the comments.

To make sure I understood correctly: you are suggesting to merge the
linlon-d6 and mali-d32 cases into a single entry and use an enum for
the first compatible string, like this:
compatible:
    oneOf:
      - items:
          - enum:
              - arm,mali-d32
              - armchina,linlon-d6
          - const: arm,mali-d71
      - const: arm,mali-d71

If so, I will send an updated patch later.

Thanks,
Cunyuan

> 
> > +          - const: arm,mali-d71
> >        - const: arm,mali-d71
> >
> >    reg:
> 
> 
> Best regards,
> Krzysztof

  reply	other threads:[~2026-03-12  8:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  5:55 [PATCH 0/3] Arm China Linlon-D6 display controller support Cunyuan Liu
2026-03-11  5:55 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Arm Technology (China) Co., Ltd Cunyuan Liu
2026-03-11 18:42   ` Conor Dooley
2026-03-11 19:15     ` Liviu Dudau
2026-03-11 20:16       ` Krzysztof Kozlowski
2026-03-11 22:37   ` Rob Herring (Arm)
2026-03-11  5:55 ` [PATCH 2/3] dt-bindings: display: arm,komeda: add Arm China Linlon D6 compatible Cunyuan Liu
2026-03-11 19:11   ` Liviu Dudau
2026-03-11 20:16   ` Krzysztof Kozlowski
2026-03-12  8:15     ` Cunyuan Liu [this message]
2026-03-12 16:06       ` Krzysztof Kozlowski
2026-03-11  5:55 ` [PATCH 3/3] drm/komeda: Add support for Arm China Linlon-D6 Cunyuan Liu
2026-03-11 19:42   ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYZPR06MB7334C88FD32F5428E4F9D263F844A@TYZPR06MB7334.apcprd06.prod.outlook.com \
    --to=cunyuan.liu@cixtech.com \
    --cc=airlied@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=dev@kael-k.io \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@nabladev.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®