From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC6AC4320A for ; Fri, 20 Aug 2021 11:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F20A860FE8 for ; Fri, 20 Aug 2021 11:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239083AbhHTLBb (ORCPT ); Fri, 20 Aug 2021 07:01:31 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:37771 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236783AbhHTLB3 (ORCPT ); Fri, 20 Aug 2021 07:01:29 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DE69D320093C; Fri, 20 Aug 2021 07:00:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 20 Aug 2021 07:00:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=dJKGL4 F0jfdJf4O3ZKguyRrO1H7CYdNtVqRZZ9k8DUQ=; b=Mz+uuVbdLmz4FDkB9GY3E5 9uEIMfyMi+8xNJx39oyV5IptyH7FPZ76nIfD2BOiRVmj+2anILJLGY/7ymMZsykx M5Z3aSEYf5rzo+nlRAF05N1kz3/8D16e7z83EoYLohezgOdpNdicl+jBKdPxJICs oePs8Osf2ys4IFUyWFkyZwA9dE4P1xUO1e4hdbRwVmFCP0H1qrB39VzAi2H+5Y8a rYWtbbXBYcZI7ID0hB4JqwERgd3AqdNvwJXJbmElbq8ZpwkbU+9pVHwr36/35eeQ tyLpcyzqxuscym1F0HGWL5Q641NzlbADxbprhfsBf25SehhmsAVIBd9+MLT+NM0g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleelgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhuffvkfgjfhfogggtsehttdertd ertddvnecuhfhrohhmpefnuhhkvgculfhonhgvshcuoehluhhkvgeslhhjohhnvghsrdgu vghvqeenucggtffrrghtthgvrhhnpefgfeefudffhffgueehgeffffeggeevieefueethf eijefftedugfeuveethedtteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehluhhkvgeslhhjohhnvghsrdguvghv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Aug 2021 07:00:45 -0400 (EDT) Date: Fri, 20 Aug 2021 23:00:30 +1200 From: Luke Jones Subject: Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves To: Bastien Nocera Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com, platform-driver-x86@vger.kernel.org Message-Id: In-Reply-To: References: <20210820095726.14131-1-luke@ljones.dev> <20210820095726.14131-2-luke@ljones.dev> <321afe1a293be3a623a9be53feea3a008e044b31.camel@hadess.net> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20 2021 at 12:51:08 +0200, Bastien Nocera wrote: > On Fri, 2021-08-20 at 12:43 +0200, Bastien Nocera wrote: >> On Fri, 2021-08-20 at 22:33 +1200, Luke Jones wrote: >> > > Am I going to get bug reports from Asus users that will complain >> > > that >> > > power-profiles-daemon doesn't work correctly, where I will have >> > > to >> > > wearily ask if they're using an Asus Rog laptop? >> > >> > No. Definitely not. The changes to fan curves per-profile need to >> > be >> > explicitly enabled and set. So a new user will be unaware that >> this >> > control exists (until they look for it) and their laptop will >> > behave >> > exactly as default. >> >> "The user will need to change the fan curves manually so will >> definitely remember to mention it in bug reports" is a very >> different >> thing to "the user can't change the fan curves to be nonsensical and >> mean opposite things". >> >> I can assure you that I will eventually get bug reports from "power >> users" who break their setup and wonder why things don't work >> properly, >> without ever mentioning the changes they made changes to the fan >> curves, or anything else they might have changed. > > A way to taint the settings that power-profiles-daemon could catch > would be fine by me. I absolutely don't want to have to support > somebody's tweaks until they undo them. Definitely understood. Do you have something in mind? >