mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Christophe Branchereau <cbranchereau@gmail.com>,
	list@opendingux.net, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] gpu/drm: ingenic: Remove bogus register write
Date: Sat, 30 Oct 2021 21:03:30 +0100	[thread overview]
Message-ID: <UP3T1R.6J62YIN55WCQ3@crapouillou.net> (raw)
In-Reply-To: <YX2T0dbyaYkIbUgs@ravnborg.org>

Hi,

Le sam., oct. 30 2021 at 20:49:53 +0200, Sam Ravnborg 
<sam@ravnborg.org> a écrit :
> Hi Paul,
> 
> On Sat, Oct 30, 2021 at 11:00:32AM +0100, Paul Cercueil wrote:
>>  Commit 1bdb542da736 ("drm/ingenic: Simplify code by using hwdescs
>>  array") caused the dma_hwdesc_phys_f{0,1} variables to be used while
>>  uninitialized in a mmio register write, which most certainly broke 
>> the
>>  ingenic-drm driver.
>> 
>>  However, the very same patchset also submitted commit 6055466203df
>>  ("drm/ingenic: Upload palette before frame"), which restored a 
>> correct
>>  behaviour by doing the register writes in a different place in the 
>> code.
>> 
>>  What's left of this, is just to remove the bogus register writes in 
>> the
>>  probe function.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  Reported-by: kernel test robot <lkp@intel.com>
> 
> Thank you lkp...
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Pushed to drm-misc-next.

Thanks!
-Paul



      parent reply	other threads:[~2021-10-30 20:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 10:00 Paul Cercueil
     [not found] ` <YX2T0dbyaYkIbUgs@ravnborg.org>
2021-10-30 20:03   ` Paul Cercueil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UP3T1R.6J62YIN55WCQ3@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=airlied@linux.ie \
    --cc=cbranchereau@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=list@opendingux.net \
    --cc=lkp@intel.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®