mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andries.Brouwer@cwi.nl
To: linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net,
	mdharm-usb@one-eyed-alien.net
Subject: Unit attention in USB storage
Date: Tue, 5 Jun 2001 03:58:03 +0200 (MET DST)	[thread overview]
Message-ID: <UTC200106050158.DAA189320.aeb@vlet.cwi.nl> (raw)

Last month my CF reader read CF cards happily.
Now that I returned from Denmark, I find that it no longer works
(with the same 2.4.3 kernel). Indeed, it is not properly detected.

The reason seems to be slightly different timing at bootup -
maybe because I connected a wheelmouse this time -
and now this device comes with Unit Attention
	(code 70, key 6, ASC 28, ASCQ 0: not ready to ready transit)
and this is regarded as an error return and the initial INQUIRY fails.

Thus, since this code actually occurs in real life, we should
probably add

	case 0x2800: what="not ready to ready transtion (media change?)";
		break;

in debug.c:usb_stor_show_sense().
I have not really thought about the proper treatment of this Unit Attention.
However, if one decides that really nothing at all is wrong when a device
tells us that it is ready now, then

                if ((srb->sense_buffer[2] & 0xf) == 0x6 /* unit attention */
                    && srb->sense_buffer[12] == 0x28
                    && srb->sense_buffer[13] == 0 /* not ready -> ready */)
                        srb->result = GOOD << 1;

is perhaps not too unreasonable. (This is in usb/storage/transport.c,
usb_stor_invoke_transport(), at the end of the need autosense part.)
Anyway, with this addition (to 2.4.3) all works for me again.

Andries

             reply	other threads:[~2001-06-05  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-05  1:58 Andries.Brouwer [this message]
2001-06-05  2:07 ` Matthew Dharm
2001-06-05  3:39 Andries.Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UTC200106050158.DAA189320.aeb@vlet.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=mdharm-usb@one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®