From: Andries.Brouwer@cwi.nl
To: greg@kroah.com, sydelko@ecn.purdue.edu
Cc: linux-kernel@vger.kernel.org, torvalds@penguin.transmeta.com
Subject: Re: 2.5.1[012] compile fix under drivers/usb/storage
Date: Wed, 1 May 2002 21:34:59 +0200 (MEST) [thread overview]
Message-ID: <UTC200205011934.g41JYxB23532.aeb@smtp.cwi.nl> (raw)
On Wed, May 01, 2002 at 09:58:57AM -0500, Andrew T Sydelko wrote:
>
> The following patch fixes compilation problems due to structure changes.
> The patch applies against 2.5.1[012].
>
> drivers/usb/storage/datafab.c
> drivers/usb/storage/jumpshot.c
I don't think this is the proper fix for this code (due to highmem
issues). Could you please work with the usb-storage author and
maintainer to get this fixed.
thanks,
greg k-h
It was already fixed in sddr09.c, so the code can be copied from there.
(Indeed, the code was cloned from there, and identical copies occur
in several drivers. I made raw_bulk.c and smartmedia.c to hold the
stuff that is repeated today.)
Andries
next reply other threads:[~2002-05-01 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-01 19:34 Andries.Brouwer [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-05-01 14:58 Andrew T Sydelko
2002-05-01 17:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200205011934.g41JYxB23532.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sydelko@ecn.purdue.edu \
--cc=torvalds@penguin.transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®