From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, viro@math.psu.edu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] 37 stack variables >= 1K in 2.4.17
Date: Mon, 17 Jun 2002 00:05:40 +0200 (MEST) [thread overview]
Message-ID: <UTC200206162205.g5GM5eJ05123.aeb@smtp.cwi.nl> (raw)
>> The result of Step One is that the loop no longer touches all
>> filesystems but lives entirely in namei.c. So, the second patch,
>> that only changes namei.c can change the recursion into iteration.
>> Maybe tomorrow or the day after.
> Obvious breakage: nd->flags can be clobbered by __vfs_follow_link(),
> so your do_follow_link() and friends are broken.
Yes, I know. No doubt you are able to fix that by reading that bit
before calling __vfs_follow_link(). It will be repaired fully
automatically tomorrow or the day after when __vfs_follow_link()
disappears altogether.
But that is the microscopic criticism. I was more interested in
hearing comments on the global setup.
Andries
next reply other threads:[~2002-06-16 22:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-16 22:05 Andries.Brouwer [this message]
2002-06-16 23:57 ` Alexander Viro
-- strict thread matches above, loose matches on Subject: below --
2002-06-17 11:07 Andries.Brouwer
2002-06-17 12:00 ` David Woodhouse
2002-06-16 20:41 Andries.Brouwer
2002-06-16 21:33 ` Andreas Dilger
2002-06-16 21:34 ` Alexander Viro
2002-06-17 10:09 ` David Woodhouse
2002-06-16 13:13 Andries.Brouwer
2002-06-16 18:51 ` Alexander Viro
2002-06-16 10:56 Andries.Brouwer
2002-06-16 11:38 ` Alexander Viro
2002-06-16 9:59 Andries.Brouwer
2002-06-16 10:33 ` Alexander Viro
2002-06-16 7:47 Andries.Brouwer
2002-06-16 8:36 ` Alexander Viro
2002-06-16 0:48 Andries.Brouwer
2002-06-16 1:08 ` Alexander Viro
2002-06-10 3:56 Dawson Engler
2002-06-12 8:43 ` Pavel Machek
2002-06-12 19:11 ` Nikita Danilov
2002-06-12 21:51 ` Benjamin LaHaise
2002-06-12 22:26 ` Alexander Viro
2002-06-12 22:38 ` Benjamin LaHaise
2002-06-12 22:44 ` Robert Love
2002-06-13 0:20 ` Alexander Viro
2002-06-13 8:30 ` Helge Hafting
2002-06-13 13:24 ` Roger Larsson
2002-06-14 10:06 ` Helge Hafting
2002-06-13 6:38 ` Dawson Engler
2002-06-13 6:59 ` Alexander Viro
2002-06-13 17:41 ` Daniel Phillips
2002-06-13 17:53 ` Alexander Viro
2002-06-13 18:45 ` Daniel Phillips
2002-06-13 17:56 ` Andi Kleen
2002-06-13 18:26 ` Alexander Viro
2002-06-13 19:01 ` Andi Kleen
2002-06-14 0:05 ` William Lee Irwin III
2002-06-13 21:50 ` Dawson Engler
2002-06-13 22:43 ` Oliver Xymoron
2002-06-14 0:25 ` Alexander Viro
2002-06-13 6:36 ` Dawson Engler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200206162205.g5GM5eJ05123.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®