From: Andries.Brouwer@cwi.nl
To: akpm@zip.com.au, linux-kernel@vger.kernel.org
Subject: [PATCH?] slab.c
Date: Mon, 27 Jan 2003 00:14:32 +0100 (MET) [thread overview]
Message-ID: <UTC200301262314.h0QNEWm00231.aeb@smtp.cwi.nl> (raw)
In slab.c the routine check_poison_obj() is called.
That routine does nothing except return 0 or 1.
Thus it looks like the present call in slab_destroy()
is meaningless. Perhaps something like this was meant?
--- slab.c~ Sat Jan 18 23:54:30 2003
+++ slab.c Mon Jan 27 00:05:47 2003
@@ -796,7 +796,8 @@
void *objp = slabp->s_mem + cachep->objsize * i;
if (cachep->flags & SLAB_POISON)
- check_poison_obj(cachep, objp);
+ if (check_poison_obj(cachep, objp))
+ BUG();
if (cachep->flags & SLAB_RED_ZONE) {
if (*((unsigned long*)(objp)) != RED_INACTIVE)
A BUG() was lost in patch 2.5.45.
Andries
next reply other threads:[~2003-01-26 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-26 23:14 Andries.Brouwer [this message]
2003-01-27 3:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200301262314.h0QNEWm00231.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®