mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andries.Brouwer@cwi.nl
To: aebr@win.tue.nl, akpm@digeo.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: Private namespaces
Date: Sun, 20 Apr 2003 00:18:36 +0200 (MEST)	[thread overview]
Message-ID: <UTC200304192218.h3JMIak17446.aeb@smtp.cwi.nl> (raw)

> How does this look?

Ach - just a moment ago I submitted only that single
improvement, but you do the whole list.

(It is OK, of course. I looked for a second and concluded that
in all other cases the return value was in fact -ENOMEM, so that
no change was required. Only in the case of security_task_alloc()
is a different value, -EPERM, likely.)

Concerning style - I don't like

	if ((retval = copy_sighand(clone_flags, p)))

very much.

Where there is an if() one expects a boolean condition,
and in superficial reading one can easily mistake = for ==,
in spite of the additional parentheses.

Just

	retval = copy_sighand(clone_flags, p);
	if (retval)

is so much clearer.

Andries

             reply	other threads:[~2003-04-19 22:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-19 22:18 Andries.Brouwer [this message]
2003-04-19 22:22 ` Andrew Morton
2003-05-05 13:23 Adrian Etchevarne
2003-04-16 13:23 ` Andries Brouwer
2003-04-19 14:52   ` Florin Iucha
2003-04-19 16:21     ` Andries Brouwer
2003-04-19 21:35       ` Andrew Morton
2003-04-16 13:40 ` Lee Causier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UTC200304192218.h3JMIak17446.aeb@smtp.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=aebr@win.tue.nl \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®