From: Andries.Brouwer@cwi.nl
To: Valdis.Kletnieks@vt.edu, manfred@colorfullife.com
Cc: Andries.Brouwer@cwi.nl, akpm@osdl.org,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] select fix
Date: Tue, 29 Jul 2003 22:18:56 +0200 (MEST) [thread overview]
Message-ID: <UTC200307292018.h6TKIum18958.aeb@smtp.cwi.nl> (raw)
From: Manfred Spraul <manfred@colorfullife.com>
Valdis.Kletnieks@vt.edu wrote:
> Would including all 3 conditions make sense?
I hesitated for a moment. These conditions are not entirely
equivalent and neither implies the other. But Manfreds
version is better. Many drivers have a write_room() that
only counts characters and the corresponding write() will fill
the buffer and only check tty->stopped before actually transmitting.
So write_room() is a better predictor.
Andries
next reply other threads:[~2003-07-29 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-29 20:18 Andries.Brouwer [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-07-29 19:58 Andries.Brouwer
2003-07-29 14:12 Andries.Brouwer
2003-07-29 17:36 ` Andrew Morton
2003-07-29 17:48 ` Valdis.Kletnieks
2003-07-29 18:09 ` Manfred Spraul
2003-07-29 17:57 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200307292018.h6TKIum18958.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®