From: Andries.Brouwer@cwi.nl
To: fw@deneb.enyo.de, linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Subject: Re: [2.6.0-test9] Strange SCSI messages
Date: Sun, 26 Oct 2003 20:33:45 +0100 (MET) [thread overview]
Message-ID: <UTC200310261933.h9QJXjN04379.aeb@smtp.cwi.nl> (raw)
From: Florian Weimer <fw@deneb.enyo.de>
| Info fld=0x440b6b, Current sdsdd: sense key Recovered Error
| Additional sense: Address mark not found for data field
According to the sources, these are SCSI messages (matbe this should be
noted in the message?) -- but what do they mean?
No doubt you are asking something else, but your sdsdd should have been sdd.
That is, these days error printing is a bit broken.
Something like the patch below might help.
Andries
diff -u --recursive --new-file -X /linux/dontdiff a/drivers/scsi/constants.c b/drivers/scsi/constants.c
--- a/drivers/scsi/constants.c Sun Oct 26 00:00:11 2003
+++ b/drivers/scsi/constants.c Sun Oct 26 20:11:07 2003
@@ -915,15 +915,15 @@
/* Print sense information */
static void
-print_sense_internal(const char * devclass,
- const unsigned char * sense_buffer,
+print_sense_internal(const char *devclass,
+ const unsigned char *sense_buffer,
struct request *req)
{
int s, sense_class, valid, code, info;
- const char * error = NULL;
+ const char *error = NULL;
unsigned char asc, ascq;
const char *sense_txt;
- char *name = req->rq_disk ? req->rq_disk->disk_name : "?";
+ const char *name = req->rq_disk ? req->rq_disk->disk_name : devclass;
sense_class = (sense_buffer[0] >> 4) & 0x07;
code = sense_buffer[0] & 0xf;
@@ -966,11 +966,9 @@
sense_txt = scsi_sense_key_string(sense_buffer[2]);
if (sense_txt)
- printk("%s%s: sense key %s\n",
- devclass, name, sense_txt);
+ printk("%s: sense key %s\n", name, sense_txt);
else
- printk("%s%s: sense = %2x %2x\n",
- devclass, name,
+ printk("%s: sense = %2x %2x\n", name,
sense_buffer[0], sense_buffer[2]);
asc = ascq = 0;
@@ -993,11 +991,9 @@
sense_txt = scsi_sense_key_string(sense_buffer[0]);
if (sense_txt)
- printk("%s%s: old sense key %s\n",
- devclass, name, sense_txt);
+ printk("%s: old sense key %s\n", name, sense_txt);
else
- printk("%s%s: sense = %2x %2x\n",
- devclass, name,
+ printk("%s: sense = %2x %2x\n", name,
sense_buffer[0], sense_buffer[2]);
printk("Non-extended sense class %d code 0x%0x\n",
next reply other threads:[~2003-10-26 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-26 19:33 Andries.Brouwer [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-26 17:49 Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200310261933.h9QJXjN04379.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=fw@deneb.enyo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®