From: Andries.Brouwer@cwi.nl
To: linux-kernel@vger.kernel.org
Subject: [PATCH - RFC] number of Solaris slices
Date: Sat, 6 Dec 2003 23:17:22 +0100 (MET) [thread overview]
Message-ID: <UTC200312062217.hB6MHM118492.aeb@smtp.cwi.nl> (raw)
People tell me that SOLARIS_X86_NUMSLICE should be 16 instead of 8.
And it seems there is some truth in that.
On the other hand, there have certainly been times that 8 was the
right number. Instead of using a define for the number of slices
(partitions, if you prefer), is it OK for all Solaris versions to
use v->v_nparts?
Andries
--- /linux/2.6/linux-2.6.0-test11/linux/fs/partitions/msdos.c Wed Nov 26 21:44:30 2003
+++ ./msdos.c Sat Dec 6 22:55:58 2003
@@ -170,7 +170,7 @@
#ifdef CONFIG_SOLARIS_X86_PARTITION
Sector sect;
struct solaris_x86_vtoc *v;
- int i;
+ int i, numslices;
v = (struct solaris_x86_vtoc *)read_dev_sector(bdev, offset+1, §);
if (!v)
@@ -186,7 +186,12 @@
put_dev_sector(sect);
return;
}
- for (i=0; i<SOLARIS_X86_NUMSLICE && state->next<state->limit; i++) {
+
+ numslices = v->v_nparts;
+ if (numslices > SOLARIS_X86_NUMSLICE)
+ numslices = SOLARIS_X86_NUMSLICE;
+
+ for (i=0; i<numslices && state->next<state->limit; i++) {
struct solaris_x86_slice *s = &v->v_slice[i];
if (s->s_size == 0)
continue;
--- /linux/2.6/linux-2.6.0-test11/linux/include/linux/genhd.h Wed Nov 26 21:43:08 2003
+++ ./genhd.h Sat Dec 6 22:53:06 2003
@@ -212,7 +212,7 @@
#ifdef CONFIG_SOLARIS_X86_PARTITION
-#define SOLARIS_X86_NUMSLICE 8
+#define SOLARIS_X86_NUMSLICE 16
#define SOLARIS_X86_VTOC_SANE (0x600DDEEEUL)
struct solaris_x86_slice {
next reply other threads:[~2003-12-06 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-06 22:17 Andries.Brouwer [this message]
2003-12-09 13:23 Mikael Pettersson
2003-12-09 14:43 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200312062217.hB6MHM118492.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®