mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marco Scardovi <scardracs@disroot.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
	Corentin Chary <corentin.chary@gmail.com>,
	"Luke D. Jones" <luke@ljones.dev>,
	Denis Benato <denis.benato@linux.dev>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/7] platform/x86: asus-armoury: add power limits quirk for G713QR
Date: Wed, 21 Oct 2026 09:30:33 +0200	[thread overview]
Message-ID: <W1K_qYn4STu-RNblanTwqQ@disroot.org> (raw)
In-Reply-To: <20261021070948.19916-2-scardracs@disroot.org>

In data mercoledì 21 ottobre 2026 09:08:13 Ora legale dell’Europa centrale, 
Marco Scardovi ha scritto:
> Add a power limits quirk entry for the ASUS G713QR laptop. The limits
> are extracted from the device's ThrottleGear XML configuration.
> 
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
>  drivers/platform/x86/asus-armoury.h | 13 changes(+/-)
>  1 file changed, 13 insertions(+), 0 deletions(-)
> 
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1132,6 +1132,19 @@
>  	},
>  	{
>  		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "G713QR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_max = 80,
> +				.ppt_pl1_spl_min = 15,
> +				.ppt_pl2_sppt_max = 80,
> +				.ppt_pl2_sppt_min = 15,
> +			},
> +		},
> +	},
> +	{
> +		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "GA401IHR"),
>  		},
>  		.driver_data = &(struct power_data) {

So I found out the problem is with disroot itself and git send-email instead 
of something else. Sending cover letter here.

From: Marco Scardovi <scardracs@disroot.org>
Date: Wed, 21 Oct 2026 08:54:47 +0200
Subject: [PATCH v4 0/7] platform/x86: asus-armoury: add/update power limits 
quirks

Hi Ilpo,
thank you for pointing it out: while adding the nv_tgp_* values the
indentation fell off, adding one too much /t into it. In the meantime one
more model has been added (for those wondering the models I add are
specifically requested on [0] and I've started adding them on batches).

Changes in v4:
 - Fix power_limits[] entry indentation (was off by one tab).
 - Add GU605CM to the list.

Changes in v3 [1]:
 - FA608PM, FA608UH, and FA608UP now include nv_tgp_min/max derived from
   AC_Config.TGP and TGPItem Level* offsets (missing in v2).

Changes in v2 [2]:
 - Corrected English grammar.

Changes in v1 [3]:
 - First release.

 1/7: add G713QR
 2/7: add FA608PM
 3/7: add FA608UH
 4/7: add FA608UP
 5/7: add GA402NV
 6/7: add G533QS
 7/7: add GU605CM

[0] https://github.com/OpenGamingCollective/asusctl/issues/124
[1] https://lore.kernel.org/all/20261016130342.69923-2-scardracs@disroot.org/
[2] https://lore.kernel.org/all/20261016121432.35071-2-scardracs@disroot.org/
[3] https://lore.kernel.org/all/20261015181850.170862-2-scardracs@disroot.org/

Signed-off-by: Marco Scardovi <scardracs@disroot.org>
-- 
2.56.0





  reply	other threads:[~2026-10-21  7:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20261021070948.19916-1-scardracs@disroot.org>
2026-10-21  7:08 ` Marco Scardovi
2026-10-21  7:30   ` Marco Scardovi [this message]
2026-10-21  7:08 ` [PATCH v4 2/7] platform/x86: asus-armoury: add power limits quirk for FA608PM Marco Scardovi
2026-10-21  7:08 ` [PATCH v4 3/7] platform/x86: asus-armoury: add power limits quirk for FA608UH Marco Scardovi
2026-10-21  7:08 ` [PATCH v4 4/7] platform/x86: asus-armoury: add power limits quirk for FA608UP Marco Scardovi
2026-10-21  7:08 ` [PATCH v4 5/7] platform/x86: asus-armoury: add power limits quirk for GA402NV Marco Scardovi
2026-10-21  7:08 ` [PATCH v4 6/7] platform/x86: asus-armoury: add power limits quirk for G533QS Marco Scardovi
2026-10-21  7:08 ` [PATCH v4 7/7] platform/x86: asus-armoury: add power limits quirk for GU605CM Marco Scardovi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=W1K_qYn4STu-RNblanTwqQ@disroot.org \
    --to=scardracs@disroot.org \
    --cc=corentin.chary@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®