From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
David Collins <collinsd@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: qcom-rpmh: add QCOM_COMMAND_DB dependency
Date: Sun, 3 Jan 2021 22:41:23 -0600 [thread overview]
Message-ID: <X/Kcc9Rj6h4pJifU@builder.lan> (raw)
In-Reply-To: <20201230145712.3133110-1-arnd@kernel.org>
On Wed 30 Dec 08:56 CST 2020, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A built-in regulator driver cannot link against a modular cmd_db driver:
>
> qcom-rpmh-regulator.c:(.text+0x174): undefined reference to `cmd_db_read_addr'
>
> There is already a dependency for RPMh, so add another one of this
> type for cmd_db.
>
> Fixes: 34c5aa2666db ("regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error")
> Fixes: 46fc033eba42 ("regulator: add QCOM RPMh regulator driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/regulator/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 53fa84f4d1e1..5abdd29fb9f3 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
> config REGULATOR_QCOM_RPMH
> tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
> depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
> + depends on QCOM_COMMAND_DB || (QCOM_COMMAND_DB=n && COMPILE_TEST)
> help
> This driver supports control of PMIC regulators via the RPMh hardware
> block found on Qualcomm Technologies Inc. SoCs. RPMh regulator
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-04 4:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 14:56 Arnd Bergmann
2021-01-04 4:41 ` Bjorn Andersson [this message]
2021-01-04 17:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/Kcc9Rj6h4pJifU@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=dianders@chromium.org \
--cc=john.stultz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome