From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F40AC433E0 for ; Mon, 4 Jan 2021 12:29:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3EEF2076D for ; Mon, 4 Jan 2021 12:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbhADM3q (ORCPT ); Mon, 4 Jan 2021 07:29:46 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:29855 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbhADM3p (ORCPT ); Mon, 4 Jan 2021 07:29:45 -0500 X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8j+IczGa4o=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.10.7 DYNA|AUTH) with ESMTPSA id e09c6dx04CNkaER (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 4 Jan 2021 13:23:46 +0100 (CET) Date: Mon, 4 Jan 2021 13:23:41 +0100 From: Stephan Gerhold To: Konrad Dybcio Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Andy Gross , Bjorn Andersson , Ohad Ben-Cohen , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] remoteproc: qcom: wcnss: Adjust voltage requirements for Pronto v2 Message-ID: References: <20201226141100.90147-1-konrad.dybcio@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201226141100.90147-1-konrad.dybcio@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Konrad, On Sat, Dec 26, 2020 at 03:11:00PM +0100, Konrad Dybcio wrote: > This is required for MSM8974 devices that cannot afford to push > the regulators further. > > Signed-off-by: Konrad Dybcio > --- > drivers/remoteproc/qcom_wcnss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c > index e2573f79a137..71480be545e4 100644 > --- a/drivers/remoteproc/qcom_wcnss.c > +++ b/drivers/remoteproc/qcom_wcnss.c > @@ -124,7 +124,7 @@ static const struct wcnss_data pronto_v2_data = { > .spare_offset = 0x1088, > > .vregs = (struct wcnss_vreg_info[]) { > - { "vddmx", 1287500, 1287500, 0 }, > + { "vddmx", 950000, 1150000, 0 }, > { "vddcx", .super_turbo = true }, > { "vddpx", 1800000, 1800000, 0 }, > }, Correct me if I'm wrong but with this change pronto_v2_data looks exactly like pronto_v1_data (qcom,pronto-v1-pil). Can you just change the compatible in qcom-msm8974.dtsi? Also, if possible MSM8974 should be also moved to corner votes via rpmpd, like in https://lore.kernel.org/linux-arm-msm/20200916104135.25085-1-stephan@gerhold.net/ Then the actual voltages don't matter anymore (all we need to do here is to temporarily scale the power domain to maximum so WCNSS can boot up). Thanks, Stephan