From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C90C433E6 for ; Tue, 5 Jan 2021 13:46:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14706229C4 for ; Tue, 5 Jan 2021 13:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728456AbhAENqy (ORCPT ); Tue, 5 Jan 2021 08:46:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:39314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727398AbhAENqx (ORCPT ); Tue, 5 Jan 2021 08:46:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1821C229C4; Tue, 5 Jan 2021 13:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609854373; bh=UJNgfrZ1/h7ksEDl8gwA5+JdzuA1EC8iTPwpYFQzm6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LxaNaAWrzRFhh3x1zXwLO0HVTJCBxDwhz3lR4UXYoVSZAQQGbK3mvFgXMQlGbN6GZ B2zI5XtlEXMqEtCf53JHVbLnfxIWQx5nSx3XMRVKEIS2kpMMQVncGjku+Cygo4M+ln RE3fnRnZ1pFVkch6a2pnBBa319/d45+TdohZatmk= Date: Tue, 5 Jan 2021 14:47:37 +0100 From: Greg KH To: eli.billauer@gmail.com Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB) Message-ID: References: <20201213170503.59017-1-eli.billauer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201213170503.59017-1-eli.billauer@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 13, 2020 at 07:05:03PM +0200, eli.billauer@gmail.com wrote: > From: Eli Billauer > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The framework for exchanging > data on a USB bus is fundamentally different from doing the same with a > PCIe interface, which leaves very little in common between the existing > driver and the new one for XillyUSB. But in this one you are talking to userspace directly through a char node, why not use the same interface that the xillybus_core.c code uses? Creating yet-another-class-device feels odd when you already have one that is in use. Try to merge them together to use the same framework, or document the heck out of why this is somehow different, yet looks the same... thanks, greg k-h