From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Corey Minyard <cminyard@mvista.com>
Cc: minyard@acm.org, Jiri Slaby <jirislaby@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
brian.bloniarz@gmail.com
Subject: Re: [PATCH 2/2] drivers:tty:pty: Fix a race causing data loss on close
Date: Thu, 7 Jan 2021 16:29:33 +0100 [thread overview]
Message-ID: <X/co3Uq719eXempQ@kroah.com> (raw)
In-Reply-To: <20210102144109.GA4173@minyard.net>
On Sat, Jan 02, 2021 at 08:41:09AM -0600, Corey Minyard wrote:
> On Mon, Nov 23, 2020 at 06:49:02PM -0600, minyard@acm.org wrote:
> > From: Corey Minyard <cminyard@mvista.com>
> >
> > Remove the tty_vhangup() from the pty code and just release the
> > redirect. The tty_vhangup() results in data loss and data out of order
> > issues.
>
> It's been a while, so ping on this. I'm pretty sure this is the right
> fix, the more I've thought about it.
Sorry, was waiting to see if someone else would review it :)
Will go do so now...
greg k-h
next prev parent reply other threads:[~2021-01-07 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 0:49 [PATCH 0/2] " minyard
2020-11-24 0:49 ` [PATCH 1/2] tty: Export redirect release minyard
2020-11-24 0:49 ` [PATCH 2/2] drivers:tty:pty: Fix a race causing data loss on close minyard
2021-01-02 14:41 ` Corey Minyard
2021-01-07 15:29 ` Greg Kroah-Hartman [this message]
2021-01-07 15:32 ` [PATCH 0/2] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/co3Uq719eXempQ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brian.bloniarz@gmail.com \
--cc=cminyard@mvista.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®