From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70A2C433E6 for ; Sun, 10 Jan 2021 17:14:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4A5522B43 for ; Sun, 10 Jan 2021 17:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbhAJRN5 (ORCPT ); Sun, 10 Jan 2021 12:13:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59978 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbhAJRN4 (ORCPT ); Sun, 10 Jan 2021 12:13:56 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyeH9-00HLGm-RA; Sun, 10 Jan 2021 18:13:11 +0100 Date: Sun, 10 Jan 2021 18:13:11 +0100 From: Andrew Lunn To: stefanc@marvell.com Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com, linux-kernel@vger.kernel.org, kuba@kernel.org, linux@armlinux.org.uk, mw@semihalf.com, rmk+kernel@armlinux.org.uk, atenart@kernel.org Subject: Re: [PATCH RFC net-next 06/19] net: mvpp2: increase BM pool size to 2048 buffers Message-ID: References: <1610292623-15564-1-git-send-email-stefanc@marvell.com> <1610292623-15564-7-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610292623-15564-7-git-send-email-stefanc@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2021 at 05:30:10PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski > > BM pool size increased to support Firmware Flow Control. > Minimum depletion thresholds to support FC is 1024 buffers. > BM pool size increased to 2048 to have some 1024 buffers > space between depletion thresholds and BM pool size. > > Signed-off-by: Stefan Chulski > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > index 89b3ede..8dc669d 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > @@ -851,8 +851,8 @@ enum mvpp22_ptp_packet_format { > #define MVPP22_PTP_TIMESTAMPQUEUESELECT BIT(18) > > /* BM constants */ > -#define MVPP2_BM_JUMBO_BUF_NUM 512 > -#define MVPP2_BM_LONG_BUF_NUM 1024 > +#define MVPP2_BM_JUMBO_BUF_NUM 2048 > +#define MVPP2_BM_LONG_BUF_NUM 2048 Hi Stefan Jumbo used to be 1/2 of regular. Do you know why? It would be nice to have a comment in the commit message about why it is O.K. to change the ratio of jumbo to regular frames, and what if anything this does for memory requirements. Andrew