From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ext4: use DEFINE_MUTEX (and mutex_init() had been too late)
Date: Wed, 23 Dec 2020 20:55:44 -0500 [thread overview]
Message-ID: <X+P1IKbjELeomyeo@mit.edu> (raw)
In-Reply-To: <20201223141254.559-1-zhengyongjun3@huawei.com>
On Wed, Dec 23, 2020 at 10:12:54PM +0800, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Why is mutex_init() too late? We only take the mutex after we
mounting an ext4 file system, and that can't happen until ext4_init_fs
is called.
- Ted
> fs/ext4/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 94472044f4c1..8776f06a639d 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -59,7 +59,7 @@
> #include <trace/events/ext4.h>
>
> static struct ext4_lazy_init *ext4_li_info;
> -static struct mutex ext4_li_mtx;
> +static DEFINE_MUTEX(ext4_li_mtx);
> static struct ratelimit_state ext4_mount_msg_ratelimit;
>
> static int ext4_load_journal(struct super_block *, struct ext4_super_block *,
> @@ -6640,7 +6640,6 @@ static int __init ext4_init_fs(void)
>
> ratelimit_state_init(&ext4_mount_msg_ratelimit, 30 * HZ, 64);
> ext4_li_info = NULL;
> - mutex_init(&ext4_li_mtx);
>
> /* Build-time check for flags consistency */
> ext4_check_flag_values();
> --
> 2.22.0
>
prev parent reply other threads:[~2020-12-24 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 14:12 Zheng Yongjun
2020-12-24 1:55 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+P1IKbjELeomyeo@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome