mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Song Chen <chensong_2000@189.cn>
Cc: linux-kernel@vger.kernel.org, abbotti@mev.co.uk,
	hsweeten@visionengravers.com
Subject: Re: [PATCH] staging: comedi: remove warnings of comedi_lrange
Date: Mon, 28 Dec 2020 15:04:47 +0100	[thread overview]
Message-ID: <X+nl/xjHSBwpqWjF@kroah.com> (raw)
In-Reply-To: <1608771498-13335-1-git-send-email-chensong_2000@189.cn>

On Thu, Dec 24, 2020 at 08:58:18AM +0800, Song Chen wrote:
> Checkpatch.pl reports "warning: struct comedi_lrange should
> normally be const" in some places, which are supposed to
> be removed.
> 
> Signed-off-by: Song Chen <chensong_2000@189.cn>
> ---
>  drivers/staging/comedi/drivers/das16.c   | 4 ++--
>  drivers/staging/comedi/drivers/jr3_pci.c | 4 ++--
>  drivers/staging/comedi/drivers/ni_670x.c | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

Never send out patches that you do not test-build yourself.  Breaking
the build is a quick way to make a maintainer grumpy :(

greg k-h

  reply	other threads:[~2020-12-28 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24  0:58 Song Chen
2020-12-28 14:04 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-12-23  2:24 chensong
2020-12-23  8:06 ` Greg KH
2020-12-29  3:50 ` kernel test robot
2020-12-29  3:56 ` kernel test robot
2020-12-29  4:00 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X+nl/xjHSBwpqWjF@kroah.com \
    --to=greg@kroah.com \
    --cc=abbotti@mev.co.uk \
    --cc=chensong_2000@189.cn \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome